Skyops 69300 #439
Merged
Skyops 69300 #439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SachinMali
approved these changes
Jan 17, 2024
froesef
reviewed
Jan 17, 2024
| # $include "../cache/marketing_query_parameters.any" | ||
| } | ||
|
|
||
| # Test-specific rules |
There was a problem hiding this comment.
I think we can drop the test-specific rules here. utm_campaign is duplicate as it's already defined in the marketing parameters file and the page one is not used in wknd tutorial and would already be covered by the * rule in /0001.
froesef
approved these changes
Jan 17, 2024
|
@SachinMali can you please help with approve & merge? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: