Target xf css issue #418
Merged
Target xf css issue #418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@knennigtri Couldnt we just add CSS?: (...or whatever needs to be unset/zero'd out) my concern is that AEM OOTB the node name is called root, so i think you'd have to go in there and change the node names everything manually (in template and any existing nodes). |
|
This is probably a simpler/more elegant solution. Let me investigate. |
changed root node to xf-root XFs updated to use xf-root root node updated to xf-root. ui.content module updated with xf-root experience fragments root node updated to xf-root Revert "ui.content module updated with xf-root" This reverts commit 189c96e. Revert "XFs updated to use xf-root" This reverts commit f4d6132. Revert "xf template and template-type updated" This reverts commit 30044a2. Update elements.scss Adds use case to remove the top padding for experience fragments imported/used in Adobe Target.
knennigtri
force-pushed
the
target-xf-css-issue
branch
from
189c96e
to
b6e3c1a
Compare
|
It looks like when an XF is imported into Target the HTML is different: Based on this snippet and @davidjgonzalez suggestion, I've updated this PR to update only elements.scss |
davidjgonzalez
approved these changes
Aug 28, 2023
SachinMali
approved these changes
Oct 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the WKND XFs in Target on a WKND page, the HTML imported into Target contains:
WKND's css library uses
body .root {to set spacing at the top of the WKND site with elements.scss:When a WKND XF is added to a WKND page using the VEC with an imported XF from AEM, the css above is applied to the XF and therefore the component padding-top is set to $header-height.
This can be fixed by fixing the template-type and template for the WKND experience fragment template.
Description
Under ui.content.sample and ui.content the
rootnodes are updated toxf-root:This allows the WKND XFs to be imported into Target without the root class and therefor, the padding is not applied:
Motivation and Context
This allows anyone to use WKND as a reference website for the AEM XF and Adobe Target integration flawlessly.
Someone can now use the pre-created XF content in WKND and apply it successfully and beautifully to the WKND site using Adobe Target without the components 'jumping around' on the page.
How Has This Been Tested?
All tested locally on 2023.06 SDK
Checklist: