Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for retrieving ETag #290

Merged
merged 4 commits into from
Jun 8, 2024
Merged

Fix for retrieving ETag #290

merged 4 commits into from
Jun 8, 2024

Conversation

slitviachenko
Copy link
Collaborator

@slitviachenko slitviachenko commented Jun 5, 2024

Description

For some reason (most likely an issue with the fragment variation creation API), the returned ETag is not always correct. It's better to directly retrieve the created variation and get the ETag from there. Additionally, I found that the created variation might not be instantly available after creation, so I added 1.5 seconds wait time.

Related Issue

https://jira.corp.adobe.com/browse/SITES-22574

Motivation and Context

How Has This Been Tested?

https://experience-qa.adobe.com/?devMode=true&shell_source=workspace&workspace=debuge1275950&shell_ims=prod&aemHost=author-p7452-e12437.adobeaemcloud.com&fragmentId=145d7832-8adc-47b7-b58d-778dc067861c#/@sitesinternal/aem/generate-variations/

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@slitviachenko slitviachenko self-assigned this Jun 5, 2024
@irenelagno
Copy link
Collaborator

@slitviachenko I'm ok with this solution as a workaround, but if we don't receive more complaints from the fields, I'd prefer to avoid delivering this fix and wait for a fix from the Sisi creak team. I found an issue really similar to the one we get: https://jira.corp.adobe.com/browse/SITES-22212. It's likely our use case is related to this one.

Copy link
Collaborator

@irenelagno irenelagno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to keep in mind to check if we need to revert when https://jira.corp.adobe.com/browse/SITES-22212 is fixed

@slitviachenko
Copy link
Collaborator Author

@irenelagno , I have added you and me as watchers to https://jira.corp.adobe.com/browse/SITES-22212

@slitviachenko slitviachenko merged commit 86cf64a into main Jun 8, 2024
3 checks passed
@slitviachenko slitviachenko deleted the debug-e1275950 branch June 8, 2024 03:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants