Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: implement feature for retrieving additional content #203

Merged
merged 12 commits into from
Jul 30, 2024
Merged

feat: implement feature for retrieving additional content #203

merged 12 commits into from
Jul 30, 2024

Conversation

vtsaplin
Copy link
Collaborator

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@vtsaplin vtsaplin changed the title feat: fetch context feat: content scraper May 3, 2024
@vtsaplin vtsaplin changed the title feat: content scraper feat: implement feature for retrieving additional content Jul 22, 2024
@vtsaplin vtsaplin marked this pull request as ready for review July 22, 2024 13:03
slitviachenko
slitviachenko approved these changes Jul 22, 2024
View reviewed changes
Copy link
Collaborator

@slitviachenko slitviachenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I have just left some non-critical comments.

prompt-templates/card.prompt Show resolved Hide resolved
actions/scraper/index.js Show resolved Hide resolved
web-src/src/components/AdditionalContextInput.js Outdated Show resolved Hide resolved
askayastha22
askayastha22 approved these changes Jul 22, 2024
View reviewed changes
Copy link
Member

@askayastha22 askayastha22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Let's approve and merge PR #291 first.

@slitviachenko
Copy link
Collaborator

@vtsaplin , Could you please check why the CI/CD checks failed on the last commit?

slitviachenko
slitviachenko approved these changes Jul 24, 2024
View reviewed changes
Copy link
Collaborator

@slitviachenko slitviachenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let also remove div:only-child:empty.

@lenaorobei
Copy link
Collaborator

@vtsaplin please resolve conflicts and let's merge it. Thanks!

@slitviachenko slitviachenko merged commit b0cbbcb into main Jul 30, 2024
3 checks passed
@slitviachenko slitviachenko deleted the fetch-content branch July 30, 2024 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lenaorobei lenaorobei lenaorobei left review comments

@askayastha22 askayastha22 askayastha22 approved these changes

@slitviachenko slitviachenko slitviachenko approved these changes

@roribio roribio Awaiting requested review from roribio

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vtsaplin @slitviachenko @lenaorobei @askayastha22