Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #50: Add prompts to Source control #120

Merged
merged 8 commits into from
Nov 28, 2023
Merged

Issue #50: Add prompts to Source control #120

merged 8 commits into from
Nov 28, 2023

Conversation

roribio
Copy link
Member

@roribio roribio commented Nov 27, 2023

Description

  • Added Adobe default prompts to source control for easier visibility, editing and generating artifacts
  • Automated generating example and bundled template files
  • Automated generating the templates.zip file
  • Added support for dashes - to the parser for strings and quotedStrings so spreadsheet filenames could use them. Files in Franklin seem to use dashes as separators.

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@roribio roribio requested review from vtsaplin and nsdere November 27, 2023 04:20
@roribio roribio self-assigned this Nov 27, 2023
Copy link
Member

@askayastha22 askayastha22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@roribio roribio merged commit 4d94bea into main Nov 28, 2023
2 checks passed
@roribio roribio deleted the issue-50 branch November 28, 2023 06:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants