-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[signature] Reflect integration methods & SDK v5 influence; Leverage v4 & v5 SDK tabs #1279
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @dimim. I have gone through the changes and I agree with everything. However, I do believe this is a good chance to make the pages easier to use, and really take advantage of the fact that there are two separate tabs, for SDK v4 and SDK v5, respectively. My comments mostly deal with changing some wording in order to make the pages specific to v4/v5, and minimise confusion. I realise this is not entirely the purpose of the present ticket, but the changes are small, and it's a good chance.
Most comments are of the form "Analogous comments apply", to act as reminders. The suggestion is the same, modulo obvious changes, as the first instance of the relevant comment.
src/content/docs/en/sdk/android/v4/integrations/signature-library.mdx
Outdated
Show resolved
Hide resolved
src/content/docs/en/sdk/android/v4/integrations/signature-library.mdx
Outdated
Show resolved
Hide resolved
src/content/docs/en/sdk/android/v4/integrations/signature-library.mdx
Outdated
Show resolved
Hide resolved
src/content/docs/en/sdk/android/v4/integrations/signature-library.mdx
Outdated
Show resolved
Hide resolved
src/content/docs/en/sdk/android/v5/integrations/signature-library.mdx
Outdated
Show resolved
Hide resolved
src/content/docs/en/sdk/ios/v5/integrations/signature-library.mdx
Outdated
Show resolved
Hide resolved
src/content/docs/en/sdk/unity/v4/integrations/signature-library.mdx
Outdated
Show resolved
Hide resolved
src/content/docs/en/sdk/unity/v5/integrations/signature-library.mdx
Outdated
Show resolved
Hide resolved
Thanks, @rscloura -- some strong points shared. Please check the inline comments & LMK if I missed anything. The separate comments were helpful, as I was double checking while going through the review (hence the last force push). Our internal ticket was also updated to reflect the extra changes & I grabbed the chance to update the resources (Android & iOS), as discussed. Happy for thoughts. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the changes, and in particular for going through the trouble of updating the screenshots. They look much better. All good from my end!
…y reflect content
…ructure, for integration purposes
Rebased with |
Related issues
Changes
Required translations