Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[signature] Reflect integration methods & SDK v5 influence; Leverage v4 & v5 SDK tabs #1279

Merged
merged 12 commits into from
Jan 24, 2025

Conversation

dimim
Copy link
Collaborator

@dimim dimim commented Jan 20, 2025

Related issues

  • Jira issue link:
  • GitHub issue link:

Changes

Required translations

Platform ZH JA KO
iOS
Android
Unity
React Native
Flutter
Cordova
Cocos2d-x
Unreal Engine
Adobe Air
Corona
Xamarin
iOS Adobe extension
Android Adobe extension

Copy link

vercel bot commented Jan 20, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
dev-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 23, 2025 2:41pm

Copy link
Collaborator

@rscloura rscloura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @dimim. I have gone through the changes and I agree with everything. However, I do believe this is a good chance to make the pages easier to use, and really take advantage of the fact that there are two separate tabs, for SDK v4 and SDK v5, respectively. My comments mostly deal with changing some wording in order to make the pages specific to v4/v5, and minimise confusion. I realise this is not entirely the purpose of the present ticket, but the changes are small, and it's a good chance.

Most comments are of the form "Analogous comments apply", to act as reminders. The suggestion is the same, modulo obvious changes, as the first instance of the relevant comment.

@dimim dimim changed the title [signature] Update integration methods & SDK v5 influence [signature] Reflect integration methods & SDK v5 influence; Leverage v4 & v5 SDK tabs Jan 22, 2025
@dimim
Copy link
Collaborator Author

dimim commented Jan 23, 2025

Hi @dimim. I have gone through the changes and I agree with everything. [...]

Thanks, @rscloura -- some strong points shared. Please check the inline comments & LMK if I missed anything. The separate comments were helpful, as I was double checking while going through the review (hence the last force push).

Our internal ticket was also updated to reflect the extra changes & I grabbed the chance to update the resources (Android & iOS), as discussed.

Happy for thoughts.

Copy link
Collaborator

@rscloura rscloura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the changes, and in particular for going through the trouble of updating the screenshots. They look much better. All good from my end!

@dimim
Copy link
Collaborator Author

dimim commented Jan 23, 2025

Rebased with master. No other changes were done.

@dimim dimim merged commit b53ae95 into main Jan 24, 2025
7 checks passed
@dimim dimim deleted the 917 branch January 24, 2025 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants