Ensure that punchblock uses .WAV extension for wav49 format #259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Does asterisk never produce .wav49? Is this documented anywhere? |
|
See the related issue: #258 Asterisk hardcodes the same extension replacement. |
|
I'm pretty sure the correct replacement is |
|
@bklang you are correct, I'll fix that. It should be .WAV I'll also write a spec. |
system123
force-pushed
the
bugfix/wav49-incorrect-extension
branch
from
e318af9
to
56582fa
Compare
|
Ok changes are now correct, and spec is passing. |
bklang
requested changes
Oct 13, 2016
| @@ -80,7 +80,8 @@ def filename | |||
| end | |||
|
|
|||
| def recording | |||
| Punchblock::Component::Record::Recording.new :uri => "file://#{filename}.#{@format}" | |||
| uri = "file://#{filename}.#{@format}".gsub('wav49', 'WAV') | |||
There was a problem hiding this comment.
One more it: to be safe, the gsub really should only be applied to @format and not the entire filename
system123
force-pushed
the
bugfix/wav49-incorrect-extension
branch
from
56582fa
to
eaf3298
Compare
bklang
approved these changes
Oct 13, 2016
benlangfeld
requested changes
Oct 14, 2016
… it with Asterisk
system123
force-pushed
the
bugfix/wav49-incorrect-extension
branch
from
eaf3298
to
b4a5dcd
Compare
|
Thanks Lloyd. Would you perhaps prep this against Adhearsion 2, which merges Punchblock? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensures that the uri returned when wav49 format is used, has the same file extension as what asterisk will use.