Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/lp_solvePath #7

Merged
merged 5 commits into from
Dec 13, 2023
Merged

Fix/lp_solvePath #7

merged 5 commits into from
Dec 13, 2023

Conversation

adfeel220
Copy link
Owner

Fix LPSolve Path

Many users are reporting the problem with lp_solve, specifically with resolving the path to lp_solve executable that's linked to the usage of Panco. This fix introduces the following approaches to address issue #4.

  • Introduce a small test upon initializing Saihu, and show a warning if lp_solve cannot be executed properly.
  • A suggestion of how to install lp_solve is printed at the end of the warning according to the user's OS.
  • Resolving the path for lp_solve is performed in the following order:
    1. Use the path written in saihu/resources/lpsolve
    2. Try to run which lp_solve and which lpsolve, and apply the result if any of them succeed.
    3. Look for the file in the program entry directory, i.e. ./lp_solve

@adfeel220 adfeel220 added the enhancement New feature or request label Dec 13, 2023
@adfeel220 adfeel220 self-assigned this Dec 13, 2023
@adfeel220 adfeel220 merged commit 2760a8e into main Dec 13, 2023
@adfeel220 adfeel220 deleted the fix/lpSolvePath branch December 13, 2023 23:01
@adfeel220 adfeel220 mentioned this pull request Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant