New: Completion icon added to transcript button (issue/33)

[lemmyadams]

Addresses #33

[cahirodoherty-learningpool]

👀

[guywillis]

Would this be an opportune time to mimic the updates to the Vimeo plugin to keep the two plugins in sync?

Reference: adaptlearning/adapt-vimeo#36

[joe-allen-89]

👍

[oliverfoster]

Would this be an opportune time to mimic the updates to the Vimeo plugin to keep the two plugins in sync?

Reference: adaptlearning/adapt-vimeo#36

It looks as though most of those things are in this plugin already. Was there any specific parts you had noticed were missing?

https://github.com/adaptlearning/adapt-vimeo/blob/724d4e75c29d146c26af8c4d0fd0cc1b51c8211f/js/adapt-vimeo.js
https://github.com/adaptlearning/adapt-youtube/blob/cacae8699461da180f263259843f0a52a1051d31/js/YouTubeView.js

[guywillis]

Yes. Specifically for the inline icon:

• There isn't a plus icon in this PR which exists in the Media and Vimeo plugins - https://github.com/adaptlearning/adapt-vimeo/pull/36/files#diff-47282ddbfde7fce64096a7bedacf2aee53b4846825c476fb38b41ec7fe8ada9aR50-R52

But I also noticed:

• There's variance in the onSkipToTranscript function and subsequent toggle inline / external transcript functions https://github.com/adaptlearning/adapt-vimeo/pull/36/files#diff-27c9e7d21edb3f1c67a0f614d84edbf4d18ea5b172f55ec5e468fb4010a2e9f0R104
• There's a small chunk of accessibility related CSS in the Vimeo plugin but missing from the YouTube plugin - https://github.com/adaptlearning/adapt-vimeo/pull/36/files#diff-47282ddbfde7fce64096a7bedacf2aee53b4846825c476fb38b41ec7fe8ada9aR18-R33
• The skip to transcript button html is different in the vimeo version - https://github.com/adaptlearning/adapt-vimeo/pull/36/files#diff-df6113c1175800ec9c8161c5600ce4c9f2a2d7974783c7ac16c55889a1f458edR7-R9
• The inline transcript template has some variance in comparison to the youtube version - https://github.com/adaptlearning/adapt-vimeo/pull/36/files#diff-df6113c1175800ec9c8161c5600ce4c9f2a2d7974783c7ac16c55889a1f458edR19-R25
• The vimeo__transcript-body-inline aria label has difference - https://github.com/adaptlearning/adapt-vimeo/pull/36/files#diff-df6113c1175800ec9c8161c5600ce4c9f2a2d7974783c7ac16c55889a1f458edR47-R53

[lemmyadams]

I don't really know anything about those changes I can copy and paste it across

[lemmyadams]

@guywillis I've updated it now to match Vimeo from your comments, could you have a review please?

[cahirodoherty-learningpool]

👀

[guywillis]

👍

Thank you

[github-actions]

🎉 This PR is included in version 3.3.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀