Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Added text component e2e tests (Issue/72) #73

Merged
merged 9 commits into from
Feb 19, 2024
Merged

Conversation

lemmyadams
Copy link
Contributor

@lemmyadams lemmyadams commented Jan 30, 2024

addresses #72

@lemmyadams lemmyadams self-assigned this Jan 30, 2024
@lemmyadams lemmyadams changed the title Issue/72 Chore: Added text component e2e tests (Issue/72) Jan 30, 2024
@lemmyadams lemmyadams marked this pull request as ready for review January 30, 2024 12:44
@ethan-lp ethan-lp self-requested a review January 30, 2024 15:48
test/e2e/text.cy.js Outdated Show resolved Hide resolved
test/e2e/text.cy.js Outdated Show resolved Hide resolved
@oliverfoster
Copy link
Member

oliverfoster commented Jan 30, 2024

Really we need a way of routing to and rendering a single component in Adapt to make component tests viably reliable.

cy.visit('#/id/c-15'); would take you to the c-15 component in situe, but there's no way of know if it's behind locking / trickle / branching, etc.

Candidate pr adaptlearning/adapt-contrib-core#495 for cy.visit('#/preview/c-15'); instead.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

Copy link
Contributor

@joe-allen-89 joe-allen-89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@lemmyadams lemmyadams merged commit debf5ec into master Feb 19, 2024
Copy link

🎉 This PR is included in version 6.1.4 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants