Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: aria-valuetext attribute added to the slider to read out scaleStepPrefix/scaleStepSuffix (fixes #211) #212

Merged
merged 3 commits into from
Jul 24, 2024
Merged

Fix: aria-valuetext attribute added to the slider to read out scaleStepPrefix/scaleStepSuffix (fixes #211) #212

merged 3 commits into from
Jul 24, 2024

Conversation

joe-allen-89
Copy link
Contributor

#211

Fix

@joe-allen-89 joe-allen-89 self-assigned this Jul 12, 2024
@joe-allen-89 joe-allen-89 linked an issue Jul 12, 2024 that may be closed by this pull request
Scale step prefix & suffix are not read out by the screen reader #211
Closed
oliverfoster
oliverfoster reviewed Jul 12, 2024
View reviewed changes
templates/slider.jsx Outdated Show resolved Hide resolved
cahirodoherty-learningpool
cahirodoherty-learningpool approved these changes Jul 16, 2024
View reviewed changes
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

kirsty-hames
kirsty-hames approved these changes Jul 24, 2024
View reviewed changes
Copy link
Contributor

@kirsty-hames kirsty-hames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected thanks. Tested with VoiceOver on Mac 👍

@kirsty-hames kirsty-hames merged commit f4f88cc into master Jul 24, 2024
github-actions bot pushed a commit that referenced this pull request Jul 24, 2024
@semantic-release-bot
Chore(release): 4.5.6 [skip ci]
407ecfa 
## [4.5.6](v4.5.5...v4.5.6) (2024-07-24)

### Fix

* aria-valuetext attribute added to the slider to read out scaleStepPrefix/scaleStepSuffix (fixes #211) (#212) ([f4f88cc](f4f88cc)), closes [#211](#211) [#212](#212) [#211](#211)
@github-actions GitHub Actions
Copy link

🎉 This PR is included in version 4.5.6 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@kirsty-hames kirsty-hames deleted the issue/211 branch July 24, 2024 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cahirodoherty-learningpool cahirodoherty-learningpool cahirodoherty-learningpool approved these changes

@oliverfoster oliverfoster oliverfoster approved these changes

@kirsty-hames kirsty-hames kirsty-hames approved these changes

Assignees

@joe-allen-89 joe-allen-89

Labels
accessibility bug released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Scale step prefix & suffix are not read out by the screen reader
4 participants
@joe-allen-89 @kirsty-hames @oliverfoster @cahirodoherty-learningpool