Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: role added to component__widget div (fixes #209) #210

Merged
merged 2 commits into from
Jul 23, 2024
Merged

Fix: role added to component__widget div (fixes #209) #210

merged 2 commits into from
Jul 23, 2024

Conversation

joe-allen-89
Copy link
Contributor

@joe-allen-89 joe-allen-89 self-assigned this Jul 11, 2024
@joe-allen-89 joe-allen-89 linked an issue Jul 11, 2024 that may be closed by this pull request
aria-labelledby/label not being announced when tabbing through. #209
Closed
This was referenced Jul 12, 2024
Closed
Merged
oliverfoster
oliverfoster reviewed Jul 15, 2024
View reviewed changes
templates/slider.jsx Outdated Show resolved Hide resolved
cahirodoherty-learningpool
cahirodoherty-learningpool approved these changes Jul 16, 2024
View reviewed changes
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

kirsty-hames
kirsty-hames approved these changes Jul 23, 2024
View reviewed changes
Copy link
Contributor

@kirsty-hames kirsty-hames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected thanks 👍 Tested with VoiceOver on Mac

@kirsty-hames kirsty-hames merged commit b66020c into master Jul 23, 2024
@kirsty-hames kirsty-hames deleted the issue/209 branch July 23, 2024 09:49
github-actions bot pushed a commit that referenced this pull request Jul 23, 2024
@semantic-release-bot
Chore(release): 4.5.5 [skip ci]
fe88727 
## [4.5.5](v4.5.4...v4.5.5) (2024-07-23)

### Fix

* role added to component__widget div (fixes #209) (#210) ([b66020c](b66020c)), closes [#209](#209) [#210](#210)
@github-actions GitHub Actions
Copy link

🎉 This PR is included in version 4.5.5 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cahirodoherty-learningpool cahirodoherty-learningpool cahirodoherty-learningpool approved these changes

@oliverfoster oliverfoster oliverfoster approved these changes

@kirsty-hames kirsty-hames kirsty-hames approved these changes

Assignees

@joe-allen-89 joe-allen-89

Labels
accessibility bug released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

aria-labelledby/label not being announced when tabbing through.
4 participants
@joe-allen-89 @kirsty-hames @oliverfoster @cahirodoherty-learningpool