Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update: remove implied aria properties from <input type="range"> (fixes #191) #195

Merged
merged 1 commit into from
Oct 27, 2023
Merged

Update: remove implied aria properties from <input type="range"> (fixes #191) #195

merged 1 commit into from
Oct 27, 2023

Conversation

kirsty-hames
Copy link
Contributor

Remove implied properties of <input type="range"> as per Mozilla ARIA slider role best practice.

_HTML's <input type="range"> implicitly has the role of slider. Do not use aria-valuemax or aria-valuemin attributes on <input type="range"> elements;

Fixes #191

@kirsty-hames kirsty-hames self-assigned this Oct 26, 2023
cahirodoherty-learningpool
cahirodoherty-learningpool approved these changes Oct 27, 2023
View reviewed changes
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

joe-allen-89
joe-allen-89 approved these changes Oct 27, 2023
View reviewed changes
Copy link
Contributor

@joe-allen-89 joe-allen-89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@joe-allen-89 joe-allen-89 merged commit f79e5bf into master Oct 27, 2023
1 check passed
@joe-allen-89 joe-allen-89 deleted the issue/191 branch October 27, 2023 08:44
github-actions bot pushed a commit that referenced this pull request Oct 27, 2023
@semantic-release-bot
Chore(release): 4.4.0 [skip ci]
da358d2 
# [4.4.0](v4.3.10...v4.4.0) (2023-10-27)

### Update

* remove implied aria properties from <input type="range"> (#195) ([f79e5bf](f79e5bf)), closes [#195](#195)
@github-actions
Copy link

🎉 This PR is included in version 4.4.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joe-allen-89 joe-allen-89 joe-allen-89 approved these changes

@cahirodoherty-learningpool cahirodoherty-learningpool cahirodoherty-learningpool approved these changes

@oliverfoster oliverfoster oliverfoster approved these changes

Assignees

@kirsty-hames kirsty-hames

Labels
accessibility released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Is role="slider", aria-valuemax and aria-valuemin needed?
4 participants
@kirsty-hames @oliverfoster @cahirodoherty-learningpool @joe-allen-89