Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Allow floats in slider position to item selection mapping (fixes #193) #194

Merged
merged 1 commit into from
Sep 22, 2023
Merged

Fix: Allow floats in slider position to item selection mapping (fixes #193) #194

merged 1 commit into from
Sep 22, 2023

Conversation

oliverfoster
Copy link
Member

@oliverfoster oliverfoster commented Sep 20, 2023 •
edited
Loading

fixes #193

Fix

  • Allow floats in slider position to item selection mapping

@oliverfoster oliverfoster self-assigned this Sep 20, 2023
@oliverfoster oliverfoster changed the title Fix: Allow floats in slider position to item selection (fixes #193) Fix: Allow floats in slider position to item selection mapping (fixes #193) Sep 20, 2023
@oliverfoster
Copy link
Member Author

implicit +1 from @paul-mediakitchen on #193 (comment)

joe-allen-89
joe-allen-89 approved these changes Sep 21, 2023
View reviewed changes
Copy link
Contributor

@joe-allen-89 joe-allen-89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

cahirodoherty-learningpool
cahirodoherty-learningpool approved these changes Sep 22, 2023
View reviewed changes
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

@oliverfoster oliverfoster merged commit a336e60 into master Sep 22, 2023
1 check passed
@oliverfoster oliverfoster deleted the issue/193 branch September 22, 2023 14:35
github-actions bot pushed a commit that referenced this pull request Sep 22, 2023
@semantic-release-bot
Chore(release): 4.3.10 [skip ci]
11e3198 
## [4.3.10](v4.3.9...v4.3.10) (2023-09-22)

### Fix

* Allow floats in slider position to item selection (fixes #193) (#194) ([a336e60](a336e60)), closes [#193](#193) [#194](#194)
@github-actions
Copy link

🎉 This PR is included in version 4.3.10 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@paulstevendev
Copy link

Thanks a million all 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joe-allen-89 joe-allen-89 joe-allen-89 approved these changes

@ethan-lp ethan-lp ethan-lp approved these changes

@cahirodoherty-learningpool cahirodoherty-learningpool cahirodoherty-learningpool approved these changes

Assignees

@oliverfoster oliverfoster

Labels
bug released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enhancement: Ability to have a decimal scale
5 participants
@oliverfoster @paulstevendev @cahirodoherty-learningpool @ethan-lp @joe-allen-89