-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New: Add _enableFilters property (fixes #115) #116
Conversation
Hi Brad, |
@cahirodoherty-learningpool Yep, that makes sense. Done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👀
Co-authored-by: Oliver Foster <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This works as expected thanks @swashbuck. Tested on Mac Safari, Chrome and FF.
🎉 This PR is included in version 5.5.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Fix #115
New
_enableFilters
option to course.json for hiding / showing filter buttons. Defaults totrue
for backwards compatibility. Filter buttons will also continue to be automatically hidden if all the item_type
properties are the same.Fix
Testing
In course.json for the
_resources
object:"_enableFilters": true
"_enableFilters": false
"_enableFilters"
property_type
value