Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New: Add _enableFilters property (fixes #115) #116

Merged
merged 11 commits into from
May 21, 2024
Merged

Conversation

swashbuck
Copy link
Contributor

@swashbuck swashbuck commented May 13, 2024

Fix #115

New

  • Adds the new _enableFilters option to course.json for hiding / showing filter buttons. Defaults to true for backwards compatibility. Filter buttons will also continue to be automatically hidden if all the item _type properties are the same.
  • Update schemas, example.json and README.md with the new property

Fix

  • Move some logic from the JSX into the JS (e.g. filter button column count).
  • Update README.md: Include a bit about overriding some settings in contentObjects.json since it was not explicitly stated. Also update the supported browser list.

Testing

In course.json for the _resources object:

  1. Test with "_enableFilters": true
  2. Test with "_enableFilters": false
  3. Test with no "_enableFilters" property
  4. Test when all resource items have the same _type value

@swashbuck swashbuck self-assigned this May 13, 2024
@swashbuck swashbuck marked this pull request as ready for review May 13, 2024 18:29
@cahirodoherty-learningpool
Copy link
Contributor

Hi Brad,
The addition of a new property qualifies this as a minor release. Can you update the PR title to a New: type and the description can have the bullets relating to the new property moved to under a New heading also.
Changing the above will allow the semantic release script to handle the bump automatically.
Thanks

@swashbuck swashbuck changed the title Fix: Add _enableFilters property (fixes #115) New: Add _enableFilters property (fixes #115) May 14, 2024
@swashbuck
Copy link
Contributor Author

Hi Brad, The addition of a new property qualifies this as a minor release. Can you update the PR title to a New: type and the description can have the bullets relating to the new property moved to under a New heading also. Changing the above will allow the semantic release script to handle the bump automatically. Thanks

@cahirodoherty-learningpool Yep, that makes sense. Done.

Copy link
Member

@oliverfoster oliverfoster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

Copy link

@kirsty-hames kirsty-hames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works as expected thanks @swashbuck. Tested on Mac Safari, Chrome and FF.

@kirsty-hames kirsty-hames merged commit 54c3461 into master May 21, 2024
@kirsty-hames kirsty-hames deleted the issue/115 branch May 21, 2024 12:58
github-actions bot pushed a commit that referenced this pull request May 21, 2024
# [5.5.0](v5.4.3...v5.5.0) (2024-05-21)

### New

* Add _enableFilters property (fixes #115) (#116) ([54c3461](54c3461)), closes [#115](#115) [#116](#116)

### Upgrade

* Bump ip from 1.1.8 to 1.1.9 (#114) ([ac33cd7](ac33cd7)), closes [#114](#114)
Copy link

🎉 This PR is included in version 5.5.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add option to hide type filters
4 participants