Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New: Added support for _canShowCorrectness #197

Merged
merged 9 commits into from
Nov 5, 2024
Merged

New: Added support for _canShowCorrectness #197

merged 9 commits into from
Nov 5, 2024

Conversation

oliverfoster
Copy link
Member

@oliverfoster oliverfoster commented Oct 1, 2024 •
edited by kirsty-hames
Loading

part of adaptlearning/adapt_framework#3597

Allows option _canShowCorrectness instead of _canShowModelAnswer, to replace the associated toggle button and display correctness directly on the component.

New

  • Added support for _canShowCorrectness
  • Show a comma separated list of correct options when _canShowCorrectness true
  • .show-correctness widget class appended for consistency with other question components. Note, there's no associated styling currently.
  • Default prefix text added for the correct options. correctAnswerPrefix and correctAnswersPrefix added to support both single and multiple correct answers. For now this just exists in course _globals but could later add a component level override if needed. Or move these to Core if shared across question components. Prefix is optional.

matching_with_updated_prefixes

Requires

ref adaptlearning/adapt-contrib-core#582

cahirodoherty-learningpool
cahirodoherty-learningpool approved these changes Oct 10, 2024
View reviewed changes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

@kirsty-hames
Copy link
Contributor

PR comment updated to include latest commits: example, readme and schemas updated. Globals correctAnswerPrefix property added.

@kirsty-hames
Copy link
Contributor

PR updated to include default prefix text added for the correct options. correctAnswerPrefix and correctAnswersPrefix added to support both single and multiple correct answers. Screenshot updated to reflect both instances.

@oliverfoster
Copy link
Member Author

+1

kirsty-hames
kirsty-hames approved these changes Nov 5, 2024
View reviewed changes
Copy link
Contributor

@kirsty-hames kirsty-hames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working as expected

@kirsty-hames kirsty-hames merged commit 35c4c08 into master Nov 5, 2024
@kirsty-hames kirsty-hames deleted the issue/3597 branch November 5, 2024 13:49
github-actions bot pushed a commit that referenced this pull request Nov 5, 2024
@semantic-release-bot
Chore(release): 7.5.0 [skip ci]
f83af11 
# [7.5.0](v7.4.6...v7.5.0) (2024-11-05)

### New

* Added support for _canShowCorrectness (#197) ([35c4c08](35c4c08)), closes [#197](#197)
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 5, 2024

🎉 This PR is included in version 7.5.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ethan-lp ethan-lp ethan-lp approved these changes

@cahirodoherty-learningpool cahirodoherty-learningpool cahirodoherty-learningpool approved these changes

@kirsty-hames kirsty-hames kirsty-hames approved these changes

Assignees

@kirsty-hames kirsty-hames

Labels
enhancement released
Projects
adapt_framework: The TODO Board
Status: Recently Released
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@oliverfoster @kirsty-hames @cahirodoherty-learningpool @ethan-lp @swashbuck