Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Add missing properties _allowOnlyUniqueAnswers and _hasItemScoring (fixes #183) #184

Merged
merged 6 commits into from
May 31, 2024

Conversation

swashbuck
Copy link
Contributor

Fixes #183

Fix

  • Adds missing properties _allowOnlyUniqueAnswers and _hasItemScoring to README.md and V1 schemas.
  • Minor updates to documentation and help text

@swashbuck swashbuck added the bug label May 20, 2024
@swashbuck swashbuck self-assigned this May 20, 2024
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

Copy link
Contributor

@kirsty-hames kirsty-hames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks @swashbuck.

Very minor point and something that tends to be inconsistent across Adapt schemas anyway but only some help/description texts end with a full stop.

Copy link
Contributor

@joe-allen-89 joe-allen-89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@joe-allen-89 joe-allen-89 merged commit 05bc834 into master May 31, 2024
@joe-allen-89 joe-allen-89 deleted the issue/183 branch May 31, 2024 09:03
github-actions bot pushed a commit that referenced this pull request May 31, 2024
## [7.4.1](v7.4.0...v7.4.1) (2024-05-31)

### Chore

* e2e tests on matching component (Issue/181) (#182) ([34e299b](34e299b)), closes [#182](#182)

### Fix

* Add missing properties _allowOnlyUniqueAnswers and _hasItemScoring (fixes #183) (#184) ([05bc834](05bc834)), closes [#183](#183) [#184](#184)
Copy link

🎉 This PR is included in version 7.4.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document _allowOnlyUniqueAnswers
4 participants