Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New: Add "is-selected" class if an option has been selected (fixes #178) #179

Merged
merged 2 commits into from
Feb 22, 2024
Merged

New: Add "is-selected" class if an option has been selected (fixes #178) #179

merged 2 commits into from
Feb 22, 2024

Conversation

swashbuck
Copy link
Contributor

Fix #178

Fix

  • Adds an is-selected class if an option has been selected

Testing

  1. Set up a Matching component with at least two options
  2. Select an option for only one of them
  3. Ensure that the selected .dropdown__btn element has the is-selected class and the other does not.

Caveats

If the placeholder text is the same as an option's text, the is-selected class will not be applied when the option is selected.

@swashbuck swashbuck self-assigned this Feb 19, 2024
cahirodoherty-learningpool
cahirodoherty-learningpool approved these changes Feb 20, 2024
View reviewed changes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

joe-allen-89
joe-allen-89 approved these changes Feb 22, 2024
View reviewed changes
Copy link
Contributor

@joe-allen-89 joe-allen-89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@joe-allen-89 joe-allen-89 merged commit 5bc9f4a into master Feb 22, 2024
@joe-allen-89 joe-allen-89 deleted the issue/178 branch February 22, 2024 15:44
github-actions bot pushed a commit that referenced this pull request Feb 22, 2024
@semantic-release-bot
Chore(release): 7.4.0 [skip ci]
6f59017 
# [7.4.0](v7.3.3...v7.4.0) (2024-02-22)

### New

* Add "is-selected" class if an option has been selected (fixes #178) (fixes #179) ([5bc9f4a](5bc9f4a)), closes [#178](#178) [#179](#179)

### Upgrade

* Bump ip from 1.1.8 to 1.1.9 (#180) ([98e5c70](98e5c70)), closes [#180](#180)
@github-actions GitHub Actions
Copy link

🎉 This PR is included in version 7.4.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joe-allen-89 joe-allen-89 joe-allen-89 approved these changes

@cahirodoherty-learningpool cahirodoherty-learningpool cahirodoherty-learningpool approved these changes

@oliverfoster oliverfoster oliverfoster approved these changes

Assignees

@swashbuck swashbuck

Labels
enhancement released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Indicate when an option has been selected
4 participants
@swashbuck @oliverfoster @cahirodoherty-learningpool @joe-allen-89