Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Indicate when an option has been selected #178

Closed
swashbuck opened this issue Feb 16, 2024 · 1 comment · Fixed by #179
Closed

Indicate when an option has been selected #178

swashbuck opened this issue Feb 16, 2024 · 1 comment · Fixed by #179
Assignees
@swashbuck
Labels
enhancement released

Comments

@swashbuck
Copy link
Contributor

swashbuck commented Feb 16, 2024 •
edited
Loading

Subject of the enhancement

It would be useful to have a CSS class that indicates when a dropdown option has been selected. When there are several dropdowns, it can be difficult to tell which dropdowns still need to be selected so that the question can be submitted. Ideally, a quick glance would let the user know what they still need to do. This is based on real user feedback from a client.

For the purpose of this ticket, we could add a CSS class to the .matching-item when a selection has been made. Then, potentially add new "selected" styles in the Vanilla theme as a separate issue.

matching
@swashbuck swashbuck self-assigned this Feb 16, 2024
@swashbuck swashbuck mentioned this issue Feb 19, 2024
Merged
joe-allen-89 pushed a commit that referenced this issue Feb 22, 2024
@swashbuck
New: Add "is-selected" class if an option has been selected (fixes #178…
5bc9f4a 
…) (fixes #179)

* Add is-selected class if an option has been selected

* Implement hasActiveOption
github-actions bot pushed a commit that referenced this issue Feb 22, 2024
@semantic-release-bot
Chore(release): 7.4.0 [skip ci]
6f59017 
# [7.4.0](v7.3.3...v7.4.0) (2024-02-22)

### New

* Add "is-selected" class if an option has been selected (fixes #178) (fixes #179) ([5bc9f4a](5bc9f4a)), closes [#178](#178) [#179](#179)

### Upgrade

* Bump ip from 1.1.8 to 1.1.9 (#180) ([98e5c70](98e5c70)), closes [#180](#180)
@github-actions GitHub Actions
Copy link

🎉 This issue has been resolved in version 7.4.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@swashbuck swashbuck

Labels
enhancement released
Projects
None yet
Milestone
No milestone
1 participant
@swashbuck