Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: notify aria-labelledby element id (fixes #327) #328

Merged
merged 1 commit into from
Nov 4, 2024
Merged

Fix: notify aria-labelledby element id (fixes #327) #328

merged 1 commit into from
Nov 4, 2024

Conversation

oliverfoster
Copy link
Member

fixes #327

Fix

  • Changed 'notify-heading' to id from class such that the aria-labelledby on the dialog can find the element

@oliverfoster oliverfoster self-assigned this Oct 28, 2024
cahirodoherty-learningpool
cahirodoherty-learningpool approved these changes Oct 29, 2024
View reviewed changes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

swashbuck
swashbuck approved these changes Oct 30, 2024
View reviewed changes
Copy link
Contributor

@swashbuck swashbuck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

kirsty-hames
kirsty-hames approved these changes Nov 4, 2024
View reviewed changes
Copy link
Contributor

@kirsty-hames kirsty-hames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@kirsty-hames kirsty-hames merged commit 9a6ca34 into master Nov 4, 2024
1 check passed
@kirsty-hames kirsty-hames deleted the issue/327 branch November 4, 2024 12:35
github-actions bot pushed a commit that referenced this pull request Nov 4, 2024
@semantic-release-bot
Chore(release): 6.15.1 [skip ci]
f75e241 
## [6.15.1](v6.15.0...v6.15.1) (2024-11-04)

### Fix

* notify aria-labelledby element id (fixes #327) (#328) ([9a6ca34](9a6ca34)), closes [#327](#327) [#328](#328)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cahirodoherty-learningpool cahirodoherty-learningpool cahirodoherty-learningpool approved these changes

@kirsty-hames kirsty-hames kirsty-hames approved these changes

@swashbuck swashbuck swashbuck approved these changes

Assignees

@oliverfoster oliverfoster

Labels
bug
Projects
adapt_framework: The TODO Board
Status: Recently Released
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Popup aria-labelledby has no defined element
4 participants
@oliverfoster @swashbuck @kirsty-hames @cahirodoherty-learningpool