Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update: Add hover and visited image options for pin images (fixes #318) #322

Merged
merged 10 commits into from
Oct 22, 2024
Merged

Update: Add hover and visited image options for pin images (fixes #318) #322

merged 10 commits into from
Oct 22, 2024

Conversation

swashbuck
Copy link
Contributor

@swashbuck swashbuck commented Oct 3, 2024 •
edited
Loading

Fix #318

New

  • Adds hover and visited image options to each _pin: srcHover and srcVisited
  • Updates schemas and documentation

Testing

Add hover and visited images to each pin.

"_pin": {
  "src": "course/en/images/hotgraphic-pin.png",
  "srcHover": "course/en/images/hotgraphic-pin-hover.png",
  "srcVisited": "course/en/images/hotgraphic-pin-visited.png"
},

Notes

I've created a separate ticket for adding visited state icons. This was previously mentioned on #318 . See #324

@swashbuck swashbuck changed the title Documentation updates Update: Completion visual indicators for pin images (fixes #318) Oct 3, 2024
@swashbuck swashbuck changed the title Update: Completion visual indicators for pin images (fixes #318) Update: Visually indicate visited state for pin images (fixes #318) Oct 3, 2024
@swashbuck swashbuck marked this pull request as ready for review October 8, 2024 22:08
@swashbuck swashbuck self-assigned this Oct 8, 2024
@swashbuck swashbuck changed the title Update: Visually indicate visited state for pin images (fixes #318) Update: Add hover and visited image options for pin images (fixes #318) Oct 8, 2024
cahirodoherty-learningpool
cahirodoherty-learningpool approved these changes Oct 10, 2024
View reviewed changes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

kirsty-hames
kirsty-hames approved these changes Oct 15, 2024
View reviewed changes
Copy link
Contributor

@kirsty-hames kirsty-hames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works as expected thanks

guywillis
guywillis approved these changes Oct 22, 2024
View reviewed changes
Copy link
Contributor

@guywillis guywillis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@swashbuck swashbuck merged commit 101825c into master Oct 22, 2024
@swashbuck swashbuck deleted the issue/318 branch October 22, 2024 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cahirodoherty-learningpool cahirodoherty-learningpool cahirodoherty-learningpool approved these changes

@guywillis guywillis guywillis approved these changes

@kirsty-hames kirsty-hames kirsty-hames approved these changes

Assignees

@swashbuck swashbuck

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add hover and visited options for pin images
4 participants
@swashbuck @kirsty-hames @guywillis @cahirodoherty-learningpool