Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: e2e tests to check _canCycleThroughPagination (fixes #312) #313

Merged
merged 3 commits into from
Jun 20, 2024
Merged

Fix: e2e tests to check _canCycleThroughPagination (fixes #312) #313

merged 3 commits into from
Jun 20, 2024

Conversation

joe-allen-89
Copy link
Contributor

#312

Fix

@joe-allen-89 joe-allen-89 self-assigned this Jun 18, 2024
@joe-allen-89 joe-allen-89 linked an issue Jun 18, 2024 that may be closed by this pull request
e2e test fails if _canCycleThroughPagination is set to true #312
Closed
@cahirodoherty-learningpool
Copy link
Contributor

I have updated my code suggestions to be a bit more concise following Lemmy's idea

joe-allen-89 and others added 2 commits June 20, 2024 14:55
@joe-allen-89 @cahirodoherty-learningpool
Update test/e2e/hotGraphic.cy.js
b913770 
Co-authored-by: Cahir O'Doherty <[email protected]>
@joe-allen-89 @cahirodoherty-learningpool
Update test/e2e/hotGraphic.cy.js
8e8e57d 
Co-authored-by: Cahir O'Doherty <[email protected]>
cahirodoherty-learningpool
cahirodoherty-learningpool approved these changes Jun 20, 2024
View reviewed changes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

@cahirodoherty-learningpool cahirodoherty-learningpool merged commit 16602b9 into master Jun 20, 2024
github-actions bot pushed a commit that referenced this pull request Jun 20, 2024
@semantic-release-bot
Chore(release): 6.13.3 [skip ci]
11b1a9b 
## [6.13.3](v6.13.2...v6.13.3) (2024-06-20)

### Fix

* e2e tests to check _canCycleThroughPagination (fixes #312) (#313) ([16602b9](16602b9)), closes [#312](#312) [#313](#313)
@github-actions GitHub Actions
Copy link

🎉 This PR is included in version 6.13.3 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lemmyadams lemmyadams lemmyadams approved these changes

@cahirodoherty-learningpool cahirodoherty-learningpool cahirodoherty-learningpool approved these changes

@oliverfoster oliverfoster oliverfoster approved these changes

Assignees

@joe-allen-89 joe-allen-89

Labels
bug released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

e2e test fails if _canCycleThroughPagination is set to true
4 participants
@joe-allen-89 @cahirodoherty-learningpool @oliverfoster @lemmyadams