Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update: Item count ARIA updates (fixes #291) #292

Merged
merged 8 commits into from
Feb 7, 2024
Merged

Update: Item count ARIA updates (fixes #291) #292

merged 8 commits into from
Feb 7, 2024

Conversation

kirsty-hames
Copy link
Contributor

  • Update .hotgraphic__pin aria-label to use item instead of popupPagination to set itemCount. This should now read "Item one of three" instead of "one slash three".

  • README accessibility updated to reflect ARIA properties used.

  • Schema help/description text amended to reflect use.

Fixes #291

@kirsty-hames kirsty-hames self-assigned this Jan 5, 2024
cahirodoherty-learningpool
cahirodoherty-learningpool approved these changes Jan 8, 2024
View reviewed changes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

joe-allen-89
joe-allen-89 approved these changes Jan 15, 2024
View reviewed changes
Copy link
Contributor

@joe-allen-89 joe-allen-89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

zubairslamdien
zubairslamdien approved these changes Feb 5, 2024
View reviewed changes
Copy link

@zubairslamdien zubairslamdien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@kirsty-hames
Remove third curly braces from course schema item text
c873481 
...as we're only expecting 'itemNumber' and 'totalItems' to return numbers back, double curly braces should be sufficient.
@kirsty-hames
Remove third curly braces from course schema item text
a8865f7 
...as we're only expecting 'itemNumber' and 'totalItems' to return numbers back, double curly braces should be sufficient.
@oliverfoster oliverfoster merged commit 3826047 into master Feb 7, 2024
@oliverfoster oliverfoster deleted the issue/291 branch February 7, 2024 12:44
github-actions bot pushed a commit that referenced this pull request Feb 7, 2024
@semantic-release-bot
Chore(release): 6.11.0 [skip ci]
5d3c294 
# [6.11.0](v6.10.1...v6.11.0) (2024-02-07)

### Update

* Item count ARIA updates (fixes #291) (#292) ([3826047](3826047)), closes [#291](#291) [#292](#292)
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 7, 2024

🎉 This PR is included in version 6.11.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joe-allen-89 joe-allen-89 joe-allen-89 approved these changes

@zubairslamdien zubairslamdien zubairslamdien approved these changes

@cahirodoherty-learningpool cahirodoherty-learningpool cahirodoherty-learningpool approved these changes

@oliverfoster oliverfoster oliverfoster approved these changes

Assignees

@kirsty-hames kirsty-hames

Labels
accessibility released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Item count ARIA is set by popupPagination not item
5 participants
@kirsty-hames @oliverfoster @cahirodoherty-learningpool @joe-allen-89 @zubairslamdien