Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update: expand _imageAlignment properties and set popup item DOM order (fixes #289) #290

Merged
merged 6 commits into from
Jan 3, 2024
Merged

Update: expand _imageAlignment properties and set popup item DOM order (fixes #289) #290

merged 6 commits into from
Jan 3, 2024

Conversation

kirsty-hames
Copy link
Contributor

@kirsty-hames kirsty-hames commented Dec 4, 2023 •
edited
Loading

  • Expand popup image _imageAlignment to support top and bottom layout as per Core Notify.
  • Make the popup item DOM order match the visual order to meet WCAG success criteria - https://www.w3.org/TR/WCAG20-TECHS/C27.html
  • Use Core image partial to reduce code duplication.

Testing PR
This requires testing with Core PR pull/479 for classNamePrefixSeparator support.

Fixes #289

@kirsty-hames kirsty-hames self-assigned this Dec 4, 2023
@oliverfoster oliverfoster mentioned this pull request Dec 5, 2023
Closed
@kirsty-hames kirsty-hames mentioned this pull request Dec 6, 2023
Merged
cahirodoherty-learningpool
cahirodoherty-learningpool approved these changes Dec 6, 2023
View reviewed changes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

joe-allen-89
joe-allen-89 approved these changes Jan 3, 2024
View reviewed changes
Copy link
Contributor

@joe-allen-89 joe-allen-89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@joe-allen-89 joe-allen-89 merged commit 95e03a4 into master Jan 3, 2024
@joe-allen-89 joe-allen-89 deleted the issue/289 branch January 3, 2024 15:08
github-actions bot pushed a commit that referenced this pull request Jan 3, 2024
@semantic-release-bot
Chore(release): 6.10.0 [skip ci]
de9d56e 
# [6.10.0](v6.9.0...v6.10.0) (2024-01-03)

### Update

* expand _imageAlignment properties and set popup item DOM order (fixes #289) (#290) ([95e03a4](95e03a4)), closes [#289](#289) [#290](#290)
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 3, 2024

🎉 This PR is included in version 6.10.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@kirsty-hames
Copy link
Contributor Author

Hey @joe-allen-89, due to the Core requirement, do we need to bump the framework version to 5.33.10?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joe-allen-89 joe-allen-89 joe-allen-89 approved these changes

@cahirodoherty-learningpool cahirodoherty-learningpool cahirodoherty-learningpool approved these changes

@oliverfoster oliverfoster oliverfoster approved these changes

Assignees

@kirsty-hames kirsty-hames

Labels
accessibility enhancement released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Popup _imageAlignment doesn't set the DOM order
4 participants
@kirsty-hames @oliverfoster @cahirodoherty-learningpool @joe-allen-89