Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Popup _imageAlignment doesn't set the DOM order #289

Closed
kirsty-hames opened this issue Nov 30, 2023 · 1 comment · Fixed by #290
Closed

Popup _imageAlignment doesn't set the DOM order #289

kirsty-hames opened this issue Nov 30, 2023 · 1 comment · Fixed by #290
Assignees
@kirsty-hames
Labels
accessibility enhancement released

Comments

@kirsty-hames
Copy link
Contributor

kirsty-hames commented Nov 30, 2023 •
edited
Loading

Subject of the issue

The popup image positioning _imageAlignment is handled via CSS flex styles instead of setting the DOM order. See screenshot below.

hotgraphic_flex

Making the DOM order match the visual order is part of the WCAG success criteria.

Expected behaviour

I'd expect this to be consistent with Core Notify where _imageAlignment deters whether to render the image before or after the body.

tutor-popup

Issue initially raised here for reference cgkineo/adapt-hint#16
@kirsty-hames kirsty-hames self-assigned this Nov 30, 2023
@kirsty-hames kirsty-hames mentioned this issue Dec 4, 2023
Merged
joe-allen-89 pushed a commit that referenced this issue Jan 3, 2024
@kirsty-hames
Update: expand _imageAlignment properties and set popup item DOM order (
95e03a4 
fixes #289) (#290)

* Use _imageAlignment condition to deter popup item content order

* popup image alignment styles updated inline with core notify

* update schema _imageAlignment property

* update schema _imageAlignment property

* update README _imageAlignment description

* use image partial for popup item image
github-actions bot pushed a commit that referenced this issue Jan 3, 2024
@semantic-release-bot
Chore(release): 6.10.0 [skip ci]
de9d56e 
# [6.10.0](v6.9.0...v6.10.0) (2024-01-03)

### Update

* expand _imageAlignment properties and set popup item DOM order (fixes #289) (#290) ([95e03a4](95e03a4)), closes [#289](#289) [#290](#290)
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 3, 2024

🎉 This issue has been resolved in version 6.10.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kirsty-hames kirsty-hames

Labels
accessibility enhancement released
Projects
None yet
Milestone
No milestone
1 participant
@kirsty-hames