Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: e2e tests on gmcq component (Issue/177) #178

Merged
merged 5 commits into from
Apr 11, 2024
Merged

Conversation

lemmyadams
Copy link
Contributor

Addresses #177

@lemmyadams
Copy link
Contributor Author

lemmyadams commented Mar 26, 2024

@cahirodoherty-learningpool on this test and the other questions I test for the buttons appearing as expected, for the submit and show feedback.
The code is:

function testQuestionButtons(buttonsObject = {btn__action: 'Submit', btn__feedback: 'Show feedback'}) {
  Object.keys(buttonsObject).forEach((key) => {
    cy.get('.${key}').should('contain', buttonsObject[key])
  })
}

Just getting your thoughts before I raise an issue on the framework

@cahirodoherty-learningpool

@cahirodoherty-learningpool on this test and the other questions I test for the buttons appearing as expected, for the submit and show feedback. The code is:

function testQuestionButtons(buttonsObject = {btn__action: 'Submit', btn__feedback: 'Show feedback'}) {
  Object.keys(buttonsObject).forEach((key) => {
    cy.get('.${key}').should('contain', buttonsObject[key])
  })
}

Just getting your thoughts before I raise an issue on the framework

This looks okay on first inspection anyway. As long as the buttonsObject is passed as a param for each plugin that uses this helper 👍

@lemmyadams
Copy link
Contributor Author

Relies on adaptlearning/adapt_framework#3533

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

@oliverfoster
Copy link
Member

oliverfoster commented Apr 8, 2024

Brackets, line endings and odd whitespace and compiled html properties.

test/e2e/gmcq.cy.js Outdated Show resolved Hide resolved
@oliverfoster oliverfoster merged commit 7964cd7 into master Apr 11, 2024
@oliverfoster oliverfoster deleted the issue/177 branch April 11, 2024 14:27
github-actions bot pushed a commit that referenced this pull request Jun 18, 2024
## [7.5.1](v7.5.0...v7.5.1) (2024-06-18)

### Chore

* e2e tests on gmcq component (Issue/177) (#178) ([7964cd7](7964cd7)), closes [#178](#178)

### Fix

* moved striphtml function outside loop (fixes #180) ([0db68fc](0db68fc)), closes [#180](#180)

### Upgrade

* Bump ip from 1.1.8 to 1.1.9 (#176) ([eeadd8f](eeadd8f)), closes [#176](#176)
Copy link

🎉 This PR is included in version 7.5.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants