-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chore: e2e tests on gmcq component (Issue/177) #178
Conversation
@cahirodoherty-learningpool on this test and the other questions I test for the buttons appearing as expected, for the submit and show feedback.
Just getting your thoughts before I raise an issue on the framework |
This looks okay on first inspection anyway. As long as the buttonsObject is passed as a param for each plugin that uses this helper 👍 |
Relies on adaptlearning/adapt_framework#3533 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👀
Brackets, line endings and odd whitespace and compiled html properties. |
## [7.5.1](v7.5.0...v7.5.1) (2024-06-18) ### Chore * e2e tests on gmcq component (Issue/177) (#178) ([7964cd7](7964cd7)), closes [#178](#178) ### Fix * moved striphtml function outside loop (fixes #180) ([0db68fc](0db68fc)), closes [#180](#180) ### Upgrade * Bump ip from 1.1.8 to 1.1.9 (#176) ([eeadd8f](eeadd8f)), closes [#176](#176)
🎉 This PR is included in version 7.5.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Addresses #177