Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New: Add _isRound option for images (fixes #174) #175

Merged
merged 3 commits into from
Jan 29, 2024
Merged

Conversation

swashbuck
Copy link
Contributor

Fix #174

New

  • Adds an _isRound property for making square images circular

Testing

Add _isRound: true to a GMCQ component that uses square images.

Expected results

Images should be circular.

@swashbuck swashbuck self-assigned this Jan 24, 2024
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👌

Copy link
Contributor

@joe-allen-89 joe-allen-89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Contributor

@guywillis guywillis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@swashbuck swashbuck merged commit 5455b60 into master Jan 29, 2024
1 check passed
@swashbuck swashbuck deleted the issue/174 branch January 29, 2024 17:33
Copy link

🎉 This PR is included in version 7.5.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add option for rounded item images
4 participants