Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update: Remove _ariaLevel override property (fixes #142) #143

Merged
merged 1 commit into from
Nov 13, 2023
Merged

Update: Remove _ariaLevel override property (fixes #142) #143

merged 1 commit into from
Nov 13, 2023

Conversation

kirsty-hames
Copy link
Contributor

Item title _ariaLevel override removed.

Since _ariaLevels were automated in Core, there's no need to manually override these now.

Fixes #142

@kirsty-hames kirsty-hames self-assigned this Oct 30, 2023
joe-allen-89
joe-allen-89 approved these changes Nov 3, 2023
View reviewed changes
Copy link
Contributor

@joe-allen-89 joe-allen-89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

cahirodoherty-learningpool
cahirodoherty-learningpool approved these changes Nov 10, 2023
View reviewed changes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

@kirsty-hames kirsty-hames merged commit c6d405c into master Nov 13, 2023
1 check passed
@kirsty-hames kirsty-hames deleted the issue/142 branch November 13, 2023 09:40
github-actions bot pushed a commit that referenced this pull request Nov 13, 2023
@semantic-release-bot
Chore(release): 7.5.0 [skip ci]
78ff072 
# [7.5.0](v7.4.3...v7.5.0) (2023-11-13)

### Update

* Remove _ariaLevel override property (fixes #142) (#143) ([c6d405c](c6d405c)), closes [#142](#142) [#143](#143)
@github-actions GitHub Actions
Copy link

🎉 This PR is included in version 7.5.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joe-allen-89 joe-allen-89 joe-allen-89 approved these changes

@cahirodoherty-learningpool cahirodoherty-learningpool cahirodoherty-learningpool approved these changes

@oliverfoster oliverfoster oliverfoster approved these changes

Assignees

@kirsty-hames kirsty-hames

Labels
accessibility released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove _ariaLevel override property
4 participants
@kirsty-hames @oliverfoster @cahirodoherty-learningpool @joe-allen-89