Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added capymoa wrapper for OUAE algorithm #184

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

DwayneAcosta
Copy link
Contributor

Added the wrapper but there are errors with implementing the serializable interface

@nuwangunasekara
Copy link
Collaborator

nuwangunasekara commented Aug 23, 2024

Apart from conflicts which is on generic classes _online_accuracy_updated_ensemble.py seems okay to me.

Might want to correct the error message :

        assert (type(learner_option) == str
            ), "Only MOA CLI strings are supported for SGBT base_learner, at the moment."

to mention OUAE instead of SGBT there. Added a comment around line.

@DwayneAcosta, @hmgomes mentioned to me that you had trouble with serializable interface for OAUE, do you still have issues?

Kindly resolve the conflicts in

 src/capymoa/classifier/__init__.py
tests/test_classifiers.py 

let me know if you need any help with that a well :)



assert (type(learner_option) == str
), "Only MOA CLI strings are supported for SGBT base_learner, at the moment."
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change SGBT to OnlineAccuracyUpdatedEnsemble

@DwayneAcosta
Copy link
Contributor Author

DwayneAcosta commented Aug 23, 2024 via email

@nuwangunasekara
Copy link
Collaborator

Hey @DwayneAcosta, would you be able to share the errors and the code with me please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants