-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Added capymoa wrapper for OUAE algorithm #184
base: main
Are you sure you want to change the base?
feat: Added capymoa wrapper for OUAE algorithm #184
Conversation
Apart from conflicts which is on generic classes Might want to correct the error message :
to mention OUAE instead of SGBT there. Added a comment around line. @DwayneAcosta, @hmgomes mentioned to me that you had trouble with serializable interface for OAUE, do you still have issues? Kindly resolve the conflicts in
let me know if you need any help with that a well :) |
|
||
|
||
assert (type(learner_option) == str | ||
), "Only MOA CLI strings are supported for SGBT base_learner, at the moment." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please change SGBT to OnlineAccuracyUpdatedEnsemble
Hi Nuwan,
Thanks for checking the algorithm! I'll make the change and do a new PR.
And yes im still having issues with the algorithm not being able to
implement the serialisable interface
Kind regards,
Dwayne
…On Fri, Aug 23, 2024 at 12:52 PM nuwangunasekara ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In src/capymoa/classifier/_online_accuracy_updated_ensemble.py
<#184 (comment)>
:
> + :param linear_option: When checked the algorithm uses a linear weighting function.
+ """
+
+
+ mapping = {
+ "learner_option": "-l",
+ "member_count_option": "-n",
+ "window_size_option": "-w",
+ "max_byte_size_option": "-m",
+ "verbose_option": "-v",
+ "linear_option": "-f",
+ }
+
+
+ assert (type(learner_option) == str
+ ), "Only MOA CLI strings are supported for SGBT base_learner, at the moment."
Please change SGBT to OnlineAccuracyUpdatedEnsemble
—
Reply to this email directly, view it on GitHub
<#184 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AYGTIZNVMWF3BRH3KSJAERLZS2BU7AVCNFSM6AAAAABM46UKT2VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDENJWGAYTQNJWGU>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Hey @DwayneAcosta, would you be able to share the errors and the code with me please? |
Added the wrapper but there are errors with implementing the serializable interface