Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🩹 fix free-threading support #50

Merged
merged 1 commit into from
Aug 5, 2024

Conversation

burgholzer
Copy link
Contributor

This tiny PR adds free-threaded python to ignore_regexes.
Without this fix, delvewheel would not ignore python313t.dll and would patch it in the wheel which, subsequently, leads to access violations when trying to import the repaired wheel.

Given that I am not too familiar with the delvewheel codebase, I am not sure if there are other places where this needs to be fixed. At least a local test run with a free-threading build confirmed this to be working.

@adang1345
Copy link
Owner

Thanks! This should be all that's needed to fix the issue.

@adang1345 adang1345 merged commit 7388417 into adang1345:master Aug 5, 2024
1 check passed
@burgholzer burgholzer deleted the free-threading branch August 5, 2024 13:50
@burgholzer
Copy link
Contributor Author

Nice. Thanks for merging so quickly!
Would it be possible to get a release with this fix out?
Happy to contribute the corresponding PR if you'd like.

@adang1345
Copy link
Owner

I'll make a new release after fixing #49. It shouldn't take too long.

@adang1345
Copy link
Owner

adang1345 commented Aug 6, 2024

New release is out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants