Drop engines older than 4.27 #370
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TBBle
reviewed
Dec 12, 2024
| @@ -9,7 +9,7 @@ The ue4-docker Python package contains a set of Dockerfiles and accompanying bui | |||
|
|
|||
| Key features include: | |||
|
|
|||
| - The six most recent versions of the Unreal Engine are supported (currently Unreal Engine 4.26 and newer). | |||
| - The six most recent versions of the Unreal Engine are supported (currently Unreal Engine 4.27 and newer). | |||
There was a problem hiding this comment.
This patch makes it 7 versions. Perhaps we just say "Six most recent plus 4.27-plus" (or whatever the official name for that 4.27-plus LTS branch is...) That's assuming we'll keep 4.27-plus support but drop 5.0 support when 5.6 is released.
| @@ -14,45 +14,12 @@ def writeFile(filename, data): | |||
| f.write(data.encode("utf-8")) | |||
|
|
|||
|
|
|||
| # Determine if we are building UE 4.25.4 | |||
| # Determine if we are building UE 4.27.0 | |||
There was a problem hiding this comment.
This comment no longer applies and can just be removed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #350
Completely untested yet, do not merge.