Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added audioio to espressif #9995

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

MarshallMiller
Copy link

@MarshallMiller MarshallMiller commented Jan 25, 2025

Added audioio support for the one esp32 board that I have (adafruit_feather_esp32_v2) but I believe it will work with other espressif boards. This is my first contribution to CircuitPython so I'm sure there will be lots of little things that I did wrong. Resolves #3898.

Copy link
Member

@jepler jepler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! This looks amazing for a first submission. I took a look at the code, but didn't test anything. I have a few small comments.

ports/espressif/common-hal/audioio/AudioOut.c Outdated Show resolved Hide resolved
ports/espressif/common-hal/audioio/AudioOut.c Show resolved Hide resolved
Copy link
Member

@jepler jepler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing the changes I requested.

@MarshallMiller MarshallMiller force-pushed the espressif-audioio-support branch from 751f316 to 4bbc390 Compare January 26, 2025 17:26
@MarshallMiller MarshallMiller force-pushed the espressif-audioio-support branch from 4bbc390 to 6f4f57e Compare January 26, 2025 17:27
@MarshallMiller
Copy link
Author

MarshallMiller commented Jan 26, 2025

rebased onto main and squashed the commits

Copy link
Member

@jepler jepler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! This looks close, but I have a few more changes to request.

ports/espressif/boards/adafruit_feather_esp32_v2/pins.c Outdated Show resolved Hide resolved
ports/espressif/common-hal/audioio/AudioOut.c Outdated Show resolved Hide resolved
ports/espressif/common-hal/audioio/AudioOut.c Show resolved Hide resolved
Copy link
Member

@jepler jepler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks good now. I still haven't tested it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement DAC-based audio (audioio) on Espressif
3 participants