Include synthio.Biquad
methods within audiofilters.Filter
#9754
+115
−5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a minor modification to the previously merged PR #9744.
This modification adds the following methods to the
audiofilters.Filter
class:audiofilters.Filter.low_pass_filter
audiofilters.Filter.high_pass_filter
audiofilters.Filter.bass_pass_filter
These new methods help facilitate the generation of
synthio.Biquad
objects for the filter effect without requiring an instance ofsynthio.Synthesizer
. It also ensures that the sample rate used for the filter calculations matches the effect.Here is a modified version of the example provided in #9744 with this change in place:
The only consideration I have is whether or not to automatically update the filter internally or return the
synthio.Biquad
object to set manually. This is how that implementation would look like: