Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tinyusb for USB Compliance Verification test #5268

Merged
merged 5 commits into from
Sep 1, 2021

Conversation

hathach
Copy link
Member

@hathach hathach commented Aug 30, 2021

This PR update tinyusb stack which has update to get nRF5x port passed the USB Compliance Verification (USBCV) test. Other ports still need a bit of tweak but will eventually pass as well hopefully. It does include a decent changes especially in MSC driver due to all corner case e.g MSC READ10 with direction bit set to output, or mis-matched in command wrapper and scsi operation etc ... Please test it out if you could, I only did a few simple test with circuitpython.

  • For USB Compliance Verification (USBCV) and how to run it please check out USB Compliance Verification Test Suite (USBCV) hathach/tinyusb#1059 . To sum up It is a good stress test with unusual case such as switching configuration 0 -> 1 -> 0, suspend/resume/remote-wakeup. Enumeration 150 times in a row as well as weird case like MSC READ10 with direction bit set to output etc ...

Before PR, circuitpython for nrf5x port failed several test case for chapter9, passed HID, failed lots of MSC test cases. With PR, it passed all the 3 test suite

usbcv

@hathach
Copy link
Member Author

hathach commented Sep 1, 2021

thank @tannewt for helping with the ci (I am a bit clueless), though somehow the new linker cause nrf52 not boot up any more (I have tried an clean and rebuild). I am not familiar enough to spot any issue.

@tannewt
Copy link
Member

tannewt commented Sep 1, 2021

thank @tannewt for helping with the ci (I am a bit clueless), though somehow the new linker cause nrf52 not boot up any more (I have tried an clean and rebuild). I am not familiar enough to spot any issue.

Thanks for testing. Sorting .data and .bss breaks it. Feels like a memory bounds issue.

Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merging so we can get this into absolute newest.

@tannewt tannewt merged commit b80ffee into adafruit:main Sep 1, 2021
@tannewt
Copy link
Member

tannewt commented Sep 2, 2021

FYI, this breaks mass storage on the RP2040.

@hathach
Copy link
Member Author

hathach commented Sep 2, 2021

@tannewt right, i plan to push the update for rp2040 and samd, it will fix by then. was about to push the update as well, but pushed back due to issue testing with nrf52, will make another PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants