Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I changed types of variables used to specify IO pins such as DC, CS, RST, MISO, CLK from int8_t to int16_t because for example on bluepill PA4 = 196, PB0 = 200, PB1 = 201 and such numbers cant fit into int8_t (that holds +-127 because of sign) and this cause the library doesnt work with stm32duino / bluepill (the RST/DC/CS pins does not output any signal to LCD). It works perfectly with int16_t.
Tested using https://github.com/stm32duino/Arduino_Core_STM32 version 2.1.0
the Adafruit-GFX-Library needs to be modified in similar way, will put another pull request for this in a moment
not tested with other platforms like AVR or ESP because I dont have such HW just now, tested using stm32f103c8 bluepill, also tested that the "graphic test" example compiles wo errors with avr / esp8266 board selected