-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Let the greedy query planner run in O(N^3) #1722
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: Johannes Kalmbach <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1722 +/- ##
=======================================
Coverage 89.86% 89.86%
=======================================
Files 389 389
Lines 37308 37334 +26
Branches 4204 4206 +2
=======================================
+ Hits 33527 33552 +25
+ Misses 2485 2484 -1
- Partials 1296 1298 +2 ☔ View full report in Codecov by Sentry. |
Quality Gate passedIssues Measures |
Signed-off-by: Johannes Kalmbach <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1-1 with Johannes, thanks a lot for the fix. We discussed a few changes
Signed-off-by: Johannes Kalmbach <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Another quick round
Signed-off-by: Johannes Kalmbach <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, I will test this end to end, write a description, and then merge this
Conformance check passed ✅No test result changes. |
No description provided.