Skip to content

Commit

Permalink
don't default datasetClauses_ in parameters
Browse files Browse the repository at this point in the history
  • Loading branch information
Qup42 committed Jan 17, 2025
1 parent c01cbb6 commit 8899e5f
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 6 deletions.
4 changes: 2 additions & 2 deletions src/util/http/UrlParser.h
Original file line number Diff line number Diff line change
Expand Up @@ -42,15 +42,15 @@ namespace sparqlOperation {
// A SPARQL 1.1 Query
struct Query {
std::string query_;
std::vector<DatasetClause> datasetClauses_{};
std::vector<DatasetClause> datasetClauses_;

bool operator==(const Query& rhs) const = default;
};

// A SPARQL 1.1 Update
struct Update {
std::string update_;
std::vector<DatasetClause> datasetClauses_{};
std::vector<DatasetClause> datasetClauses_;

bool operator==(const Update& rhs) const = default;
};
Expand Down
8 changes: 4 additions & 4 deletions test/ServerTest.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -122,10 +122,10 @@ TEST(ServerTest, parseHttpRequest) {
EXPECT_THAT(parse(MakePostRequest("/", URLENCODED, "cmd=clear-cache")),
ParsedRequestIs("/", {{"cmd", {"clear-cache"}}}, None{}));
EXPECT_THAT(parse(MakePostRequest("/", QUERY, "SELECT * WHERE {}")),
ParsedRequestIs("/", {}, Query{"SELECT * WHERE {}"}));
EXPECT_THAT(
parse(MakePostRequest("/?send=100", QUERY, "SELECT * WHERE {}")),
ParsedRequestIs("/", {{"send", {"100"}}}, Query{"SELECT * WHERE {}"}));
ParsedRequestIs("/", {}, Query{"SELECT * WHERE {}", {}}));
EXPECT_THAT(parse(MakePostRequest("/?send=100", QUERY, "SELECT * WHERE {}")),
ParsedRequestIs("/", {{"send", {"100"}}},
Query{"SELECT * WHERE {}", {}}));
AD_EXPECT_THROW_WITH_MESSAGE(
parse(MakeBasicRequest(http::verb::patch, "/")),
testing::StrEq(
Expand Down

0 comments on commit 8899e5f

Please sign in to comment.