CardTypes: Adding card type to gateways #5384
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Heavyblade
reviewed
Jan 20, 2025
| File.write(path, updated_content) | ||
| end | ||
|
|
||
| def update_test_file(path, new_card_type) |
There was a problem hiding this comment.
💬 Comment
This is the world we live in now, a proper prompt will compete with our best Regex:
prompt =>
I want add a new type of card called "dava" to the list of supported types for the 3 gateways listed, I also want to update the corresponding unit tests adding "dava" to the list of cards that the test checks
There was a problem hiding this comment.
Yes, it would be great to figure out how we can automate this kind of update using scripts or prompts like this
Description ------------------------- This commit introduces a script to add new card types to gateways. The script updates the gateway classes by adding the new card type to the supported_cardtypes variable. Additionally, it updates the gateway test files to validate the supported card types. Update all gateways: `/script/generate card_type new_card_type` Update specific gateways: `./script/generate card_type new_card_type --gateways stripe authorize_net paypal` Update a single gateway: `./script/generate card_type new_card_type --gateways stripe`
javierpedrozaing
force-pushed
the
add_card_types_to_gateway
branch
from
8df8f79 to
01ee43f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This commit is a script to add card types to gateways
The script update the gateway classes adding the new card type in
supported_cardtypesvariable, additionally update the gateway test file to validate card types supportedUpdate all gateways:
/script/generate card_type new_card_typeUpdate specific gateways:
./script/generate card_type new_card_type --gateways stripe authorize_net paypalUpdate a single gateway:
./script/generate card_type new_card_type --gateways stripe