Nuvei: Fix 3ds transaction #5382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Description ------------------------- [SER-1568](https://spreedly.atlassian.net/browse/SER-1568) This commit fixes a 3DS transaction issue when three_ds_2 data is null. Additionally, some remote test were failing due some changes in the Nuvei Api, so this commit inlcude a round_down method to fix remote tests. Unit test ------------------------- Finished in 1.349927 seconds. 29 tests, 161 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed 21.48 tests/s, 119.27 assertions/s Remote test ------------------------- Finished in 270.209319 seconds. 43 tests, 139 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed 0.16 tests/s, 0.51 assertions/s Rubocop ------------------------- 806 files inspected, no offenses detected
naashton
approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
SER-1568
This commit fixes a 3DS transaction issue when three_ds_2 data is null. Additionally, some remote test were failing due some changes in the Nuvei Api, so this commit inlcude a round_down method to fix remote tests.
Unit test
Finished in 1.349927 seconds.
29 tests, 161 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed
21.48 tests/s, 119.27 assertions/s
Remote test
Finished in 270.209319 seconds.
43 tests, 139 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed
0.16 tests/s, 0.51 assertions/s
Rubocop
806 files inspected, no offenses detected