-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reworked AKS deployment workflows #1403
Merged
bishal-pdMSFT
merged 13 commits into
actions:partner_templates
from
tbarnes94:partner_templates
Feb 24, 2022
Merged
Reworked AKS deployment workflows #1403
bishal-pdMSFT
merged 13 commits into
actions:partner_templates
from
tbarnes94:partner_templates
Feb 24, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tbarnes94
changed the title
rebased to partner_templates
Reworked AKS deployment workflows
Feb 11, 2022
@puicchan please review these templates. |
anuragc617
reviewed
Feb 15, 2022
anuragc617
reviewed
Feb 15, 2022
deployments/properties/azure-kubernetes-service-kustomize.properties.json
Outdated
Show resolved
Hide resolved
deployments/properties/azure-kubernetes-service-kompose.properties.json
Outdated
Show resolved
Hide resolved
deployments/properties/azure-kubernetes-service-helm.properties.json
Outdated
Show resolved
Hide resolved
deployments/properties/azure-kubernetes-service.properties.json
Outdated
Show resolved
Hide resolved
anuragc617
reviewed
Feb 16, 2022
deployments/properties/azure-kubernetes-service-helm.properties.json
Outdated
Show resolved
Hide resolved
bishal-pdMSFT
approved these changes
Feb 24, 2022
Looks good to me. cc @anuragc617 |
@bishal-pdMSFT Have addressed the remaining comments, OK to merge. cc @anuragc617 |
23 tasks
23 tasks
bishal-pdMSFT
added a commit
that referenced
this pull request
Apr 22, 2022
* Reworked AKS deployment workflows (#1403) * rebased to partner_templates * Renaming workflow * Updated corresponding properties.json files for the new aks workflows under deployments. * Updated properties.json titles for aks workflows * Renamed SECRET_NAME to IMAGE_PULL_SECRET_NAME * Moved permissions down to the job level * Updated documentation links * Updated permission for action to read * Removing redundant permissions * write -> read for actions * Updated descriptions * Less reference documentation in header * Added comments to each AKS Starter Workflow step Co-authored-by: Tommy Barnes <[email protected]> * Update AKS workflows to not use imagePullSecrets (#1494) * removing old method of adding imagePullSecrets * fixing step casing * For testing: Dependency review starter workflow * changed back to image pull secret, added mask, clarified website and pull secret instructions * made changes to other aks files * Added back imagepullsecrets param to deploy action, reordered env vars * changing release version of deploy action * restructured starter workflows to parallelize secret creation and image building * renamed to buildImage and removed extra space * cleaned up some random newlines * removed extra space * removing changes from partner branch * removing changes from partner branch * through mistake in changing PR, two files lost step for createSecret Co-authored-by: Tommy Barnes <[email protected]> Co-authored-by: Tommy Barnes <[email protected]> Co-authored-by: Israel Miller <[email protected]> Co-authored-by: Bishal Prasad <[email protected]> Co-authored-by: Jaiveer Katariya <[email protected]> Co-authored-by: Jaiveer Katariya <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-requisites
Please note that at this time we are only accepting new starter workflows for Code Scanning. Updates to existing starter workflows are fine.
Tasks
For all workflows, the workflow:
.yml
file with the language or platform as its filename, in lower, kebab-cased format (for example,docker-image.yml
). Special characters should be removed or replaced with words as appropriate (for example, "dotnet" instead of ".NET").GITHUB_TOKEN
so that the workflow runs successfully.For CI workflows, the workflow:
ci
directory.ci/properties/*.properties.json
file (for example,ci/properties/docker-publish.properties.json
).push
tobranches: [ $default-branch ]
andpull_request
tobranches: [ $default-branch ]
.release
withtypes: [ created ]
.docker-publish.yml
).For Code Scanning workflows, the workflow:
code-scanning
directory.code-scanning/properties/*.properties.json
file (for example,code-scanning/properties/codeql.properties.json
), with properties set as follows:name
: Name of the Code Scanning integration.organization
: Name of the organization producing the Code Scanning integration.description
: Short description of the Code Scanning integration.categories
: Array of languages supported by the Code Scanning integration.iconName
: Name of the SVG logo representing the Code Scanning integration. This SVG logo must be present in theicons
directory.push
tobranches: [ $default-branch, $protected-branches ]
andpull_request
tobranches: [ $default-branch ]
. We also recommend aschedule
trigger ofcron: $cron-weekly
(for example,codeql.yml
).Some general notes:
actions
organization, or