Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Passing arch to the nix install script and adjusting brew libs + use macos-14 to build if needed #277

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Passing arch to the nix install script and adjusting brew libs + use macos-14 to build if needed #277

wants to merge 5 commits into from

Commits on May 29, 2024

  1. Don't hardcode to brew prefix, not the same on arm64 + adjust tcl-tk … 

    …options for 3.11+

-with-tcl-tk-xxx configure options removed in python 3.11.0, use env vars

https://github.com/python/cpython/blob/762f489b31afe0f0589aa784bf99c752044e7f30/Doc/whatsnew/3.11.rst#L2167-L2172

tcl-tk includes are in a subdir on recent homebrew recipe

https://github.com/pyenv/pyenv/blob/0167890c8c8e66bb1aaa579725a27279d31afb96/plugins/python-build/bin/python-build#L1679C7-L1687
    @jmarrec
    jmarrec committed May 29, 2024
    Configuration menu
    Copy the full SHA
    4685626 View commit details
    Browse the repository at this point in the history

  2. Print influencial env vars (CFLAGS/LDFLAGS, etc)

    @jmarrec
    jmarrec committed May 29, 2024
    Configuration menu
    Copy the full SHA
    582fe5f View commit details
    Browse the repository at this point in the history

  3. Pass arch to the install nix script

    @jmarrec
    jmarrec committed May 29, 2024
    Configuration menu
    Copy the full SHA
    1f52246 View commit details
    Browse the repository at this point in the history

  4. Use macos-14 (arm64) to prepare the package. 

    There are several issues if it ends up building:
* The toolcache location is wrong
* It links to x64 libs, like /usr/local/opt/libintl
    @jmarrec
    jmarrec committed May 29, 2024
    Configuration menu
    Copy the full SHA
    e878f62 View commit details
    Browse the repository at this point in the history

  5. Force build on macos-arm64 

    I cannot **link** to the resulting python dylib otherwise.
    @jmarrec
    jmarrec committed May 29, 2024
    Configuration menu
    Copy the full SHA
    00663d1 View commit details
    Browse the repository at this point in the history