-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: add support for commit
input (fixes #1634)
#1858
Open
testersen
wants to merge
9
commits into
actions:main
Choose a base branch
from
testersen:feature/input-commit
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: James Bradlee <[email protected]>
Signed-off-by: James Bradlee <[email protected]>
…ed but not ref Signed-off-by: James Bradlee <[email protected]>
Signed-off-by: James Bradlee <[email protected]>
Signed-off-by: James Bradlee <[email protected]>
Signed-off-by: James Bradlee <[email protected]>
Signed-off-by: James Bradlee <[email protected]>
Signed-off-by: James Bradlee <[email protected]>
…t provided. Signed-off-by: James Bradlee <[email protected]>
commit
inputcommit
input (fixed #1634)
commit
input (fixed #1634)commit
input (fixes #1634)
cc @joshmgross - we @TelenorNorgeInternal were hoping to get this merged soon ™️ would you by any chance have time to review sometime before September? Thanks in advance! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1634
This pull request adds support for supplying a commit input. This is necessary in order to replicate the standard behavior in pull request synchronization events when not using the default values.
commit
input in theaction.yaml
fileinput-helper
file, beforesettings.ref
is checked and assigned default values, setsettings.commit
to equal theinputs.commit
.input-helper
file, changesettings.ref = core.getInput('ref')
tosettings.ref = core.getInput('ref') ?? settings.ref
as a fallback for when thecommit
input was specified, but not theref
input.settings.ref
fallback tosettings.commit
, validate that thesettings.commit
, if defined, has the format of a full SHA sum.npm run format
npm run build
input-helper
, change thesettings.ref
fallback from using??
to||
, becuasesettings.ref
might be an empty string or null, causing??
to not have the desired effect. Also updated the test to reflect the fallback behavior.