[WIP] improve(SpokePoolClient): Support restart of failed listener #1721
+46
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the event that a child process terminates improperly, support restarting it with its initial lookback.
pxrl
requested review from
mrice32,
nicholaspai and
james-a-morris
as code owners
pxrl
changed the title
nicholaspai
reviewed
Jul 30, 2024
| }); | ||
|
|
||
| // Flush all ingested deposits to protect against re-org. | ||
| // xxx this probably belongs upstream in a `protected SpokePoolClient.init()` method |
There was a problem hiding this comment.
agreed with putting this into init() to avoid any missed line items
pxrl
commented
Jul 30, 2024
Comment on lines
+125
to
+127
| // xxx this probably belongs upstream in a `protected SpokePoolClient.init()` method | ||
| // that is called in the constructor, such that it can be re-called by this method to | ||
| // re-initialise the same defaults. |
There was a problem hiding this comment.
I will upstream this to the SDK.
nicholaspai
approved these changes
Jul 30, 2024
👍 There's no burning need for it right now, but it's going to be important as we add more chains with more questionable websocket reliability. I'll upstream the init method first and then will circle back to this one. |
| * @returns void | ||
| */ | ||
| protected childExit(code?: number, signal?: string): void { | ||
| if (code === 0) { |
There was a problem hiding this comment.
Is there any system defined constants (like EXIT_SUCCESS in the stdlib for C) that we can use instead of 0?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the event that a child process terminates improperly, support restarting it with its initial lookback.