chore: Added CI and fixed Clippy warnings

acridotheres · Aug 2, 2024 · 337b7c4 · 337b7c4
1 parent 0070c2d
commit 337b7c4
Show file tree

Hide file tree

Showing 7 changed files with 57 additions and 20 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -0,0 +1,20 @@
+name: Run CI
+on: [push, pull_request]
+env:
+  CARGO_TERM_COLOR: always
+  RUST_BACKTRACE: full
+jobs:
+  ci:
+    runs-on: ubuntu-latest
+
+    steps:
+      - name: Set up Rust
+        uses: actions/checkout@v4
+      - name: Install cargo-audit
+        run: cargo install cargo-audit
+      - name: Build
+        run: cargo build --verbose
+      - name: Run clippy
+        run: cargo clippy --verbose -- -D warnings
+      - name: Run audit
+        run: cargo audit
diff --git a/.vscode/extensions.json b/.vscode/extensions.json
@@ -0,0 +1,16 @@
+{
+    "recommendations": [
+        "github.vscode-github-actions",
+        "ms-vscode.hexeditor",
+        "wakatime.vscode-wakatime",
+        "github.vscode-pull-request-github",
+        "fill-labs.dependi",
+        "tamasfe.even-better-toml",
+        "github.remotehub",
+        "dustypomerleau.rust-syntax",
+        "rust-lang.rust-analyzer",
+        "vadimcn.vscode-lldb",
+        "usernamehw.errorlens",
+        "gruntfuggly.todo-tree"
+    ]
+}
diff --git a/.vscode/settings.json b/.vscode/settings.json
@@ -1,3 +1,12 @@
 {
-    "editor.tabSize": 4
+    "editor.tabSize": 4,
+    "errorLens.enabled": true,
+    "errorLens.gutterIconsEnabled": true,
+    "errorLens.gutterIconSet": "squareRounded",
+    "todo-tree.regex.regex": "(//|#|<!--|;|/\\*|^|^[ \\t]*(-|\\d+.))\\s*($TAGS)|todo!|unimplemented!",
+    "rust-analyzer.check.command": "clippy",
+    "[rust]": {
+        "editor.defaultFormatter": "rust-lang.rust-analyzer",
+        "editor.formatOnSave": true,
+    },
 }
diff --git a/src/commands/create.rs b/src/commands/create.rs
@@ -9,13 +9,10 @@ pub fn create(format: String, input: String, output: String, buffer_size: u64) {
         .split(';')
         .map(|file| {
             let file = file.split(':').collect::<Vec<&str>>();
-            let source_path = file.get(0).unwrap();
+            let source_path = file.first().unwrap();
             let mut target_path = source_path;
-            match file.get(1) {
-                Some(path) => {
-                    target_path = path;
-                }
-                None => {}
+            if let Some(path) = file.get(1) {
+                target_path = path;
             }
             EntrySource {
                 path: target_path.to_string(),

diff --git a/src/commands/list.rs b/src/commands/list.rs
@@ -9,13 +9,10 @@ pub fn list(format_string: String, input: String, check_integrity: bool, buffer_
 
     match format {
         Formats::Zip => {
-            let metadata = match *metadata {
-                OriginalArchiveMetadata::Zip(metadata) => metadata,
-            };
+            let OriginalArchiveMetadata::Zip(metadata) = *metadata;
 
-            let mut i: u32 = 0;
-            println!("");
-            for file in &metadata.files {
+            println!();
+            for (i, file) in (0_u32..).zip(metadata.files.iter()) {
                 println!("{}", file.path);
                 println!("{}", "=".repeat(file.path.len()));
                 println!("Index: {}", i);
@@ -26,7 +23,7 @@ pub fn list(format_string: String, input: String, check_integrity: bool, buffer_
                         "Size: {} ({} compressed)",
                         byte_unit::Byte::from_u64(file.uncompressed_size.into())
                             .get_appropriate_unit(byte_unit::UnitType::Decimal),
-                        byte_unit::Byte::from_u64(file.size.into())
+                        byte_unit::Byte::from_u64(file.size)
                             .get_appropriate_unit(byte_unit::UnitType::Decimal)
                     );
                     println!(
@@ -36,7 +33,6 @@ pub fn list(format_string: String, input: String, check_integrity: bool, buffer_
                     println!("CRC-32 checksum: 0x{:x}", file.checksum);
                     println!("Compression method: {}\n", file.compression);
                 };
-                i += 1;
             }
         }
     }

diff --git a/src/commands/metadata.rs b/src/commands/metadata.rs
@@ -9,9 +9,7 @@ pub fn metadata(format_string: String, input: String, check_integrity: bool, buf
 
     match format {
         Formats::Zip => {
-            let metadata = match *metadata {
-                OriginalArchiveMetadata::Zip(metadata) => metadata,
-            };
+            let OriginalArchiveMetadata::Zip(metadata) = *metadata;
 
             println!("Type: {}", format_string);
             let mut file_count: u32 = 0;
@@ -36,7 +34,7 @@ pub fn metadata(format_string: String, input: String, check_integrity: bool, buf
             for file in &metadata.files {
                 total_size += file.size;
             }
-            let total_size = byte_unit::Byte::from_u64(total_size.into())
+            let total_size = byte_unit::Byte::from_u64(total_size)
                 .get_appropriate_unit(byte_unit::UnitType::Decimal);
             println!("Total size (compressed): {}", total_size);
         }

diff --git a/src/main.rs b/src/main.rs
@@ -1,4 +1,5 @@
-//mod text;
+#![allow(clippy::too_many_arguments)]
+
 mod commands;
 
 use clap::Parser;