Skip to content

Commit

Permalink
add lowercase emails to when in registration test (#408)
Browse files Browse the repository at this point in the history
* change email to lowercase in whens

* update version number
  • Loading branch information
maxwn04 authored Mar 7, 2024
1 parent 9aac2d1 commit db9d7db
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 11 deletions.
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@acmucsd/membership-portal",
"version": "3.4.1",
"version": "3.4.2",
"description": "REST API for ACM UCSD's membership portal.",
"main": "index.d.ts",
"files": [
Expand Down
20 changes: 10 additions & 10 deletions tests/auth.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ describe('account registration', () => {

// register member
const emailService = mock(EmailService);
when(emailService.sendEmailVerification(user.email, user.firstName, anyString()))
when(emailService.sendEmailVerification(user.email.toLowerCase(), user.firstName, anyString()))
.thenResolve();
const authController = ControllerFactory.auth(conn, instance(emailService));
const registerRequest = { user };
Expand Down Expand Up @@ -89,7 +89,7 @@ describe('account registration', () => {
});

const emailService = mock(EmailService);
when(emailService.sendEmailVerification(user.email, user.firstName, anyString()))
when(emailService.sendEmailVerification(user.email.toLowerCase(), user.firstName, anyString()))
.thenResolve();
const authController = ControllerFactory.auth(conn, instance(emailService));
const registerRequest = { user };
Expand All @@ -113,7 +113,7 @@ describe('account registration', () => {
});

const emailService = mock(EmailService);
when(emailService.sendEmailVerification(user.email, user.firstName, anyString()))
when(emailService.sendEmailVerification(user.email.toLowerCase(), user.firstName, anyString()))
.thenResolve();
const authController = ControllerFactory.auth(conn, instance(emailService));
const registerRequest = { user };
Expand All @@ -140,7 +140,7 @@ describe('account registration', () => {

// register member
const emailService = mock(EmailService);
when(emailService.sendEmailVerification(user.email, user.firstName, anyString()))
when(emailService.sendEmailVerification(user.email.toLowerCase(), user.firstName, anyString()))
.thenResolve();
const authController = ControllerFactory.auth(conn, instance(emailService));
const registerRequest = { user };
Expand All @@ -163,7 +163,7 @@ describe('account registration', () => {

// register member
const emailService = mock(EmailService);
when(emailService.sendEmailVerification(user.email, user.firstName, anyString()))
when(emailService.sendEmailVerification(user.email.toLowerCase(), user.firstName, anyString()))
.thenResolve();
const authController = ControllerFactory.auth(conn, instance(emailService));
const registerRequest = { user };
Expand Down Expand Up @@ -283,7 +283,7 @@ describe('verifying email', () => {
.write();

const emailService = mock(EmailService);
when(emailService.sendEmailVerification(member.email, member.firstName, anyString()))
when(emailService.sendEmailVerification(member.email.toLowerCase(), member.firstName, anyString()))
.thenResolve();
const authController = ControllerFactory.auth(conn, instance(emailService));
await authController.verifyEmail({ accessCode });
Expand All @@ -305,7 +305,7 @@ describe('verifying email', () => {
.write();

const emailService = mock(EmailService);
when(emailService.sendEmailVerification(member.email, member.firstName, anyString()))
when(emailService.sendEmailVerification(member.email.toLowerCase(), member.firstName, anyString()))
.thenResolve();
const authController = ControllerFactory.auth(conn, instance(emailService));
await expect(authController.verifyEmail({ accessCode: FactoryUtils.randomHexString() }))
Expand All @@ -326,7 +326,7 @@ describe('resending email verification', () => {
.write();

const emailService = mock(EmailService);
when(emailService.sendEmailVerification(member.email, member.firstName, anyString()))
when(emailService.sendEmailVerification(member.email.toLowerCase(), member.firstName, anyString()))
.thenResolve();
const authController = ControllerFactory.auth(conn, instance(emailService));
const params = { email: member.email };
Expand Down Expand Up @@ -478,7 +478,7 @@ describe('resending password reset email', () => {
.write();

const emailService = mock(EmailService);
when(emailService.sendPasswordReset(member.email, member.firstName, anyString()));
when(emailService.sendPasswordReset(member.email.toLowerCase(), member.firstName, anyString()));
const authController = ControllerFactory.auth(conn, instance(emailService));
const params = { email: member.email };
await authController.sendPasswordResetEmail(params, FactoryUtils.randomHexString());
Expand All @@ -495,7 +495,7 @@ describe('resending password reset email', () => {
const member = UserFactory.fake();

const emailService = mock(EmailService);
when(emailService.sendPasswordReset(member.email, member.firstName, anyString()));
when(emailService.sendPasswordReset(member.email.toLowerCase(), member.firstName, anyString()));
const authController = ControllerFactory.auth(conn, instance(emailService));
const params = { email: member.email };
await expect(authController.sendPasswordResetEmail(params, FactoryUtils.randomHexString()))
Expand Down

0 comments on commit db9d7db

Please sign in to comment.