-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement footer #12
Implement footer #12
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On Android Chrome at least, there appears to be horizontal scroll. Maybe add max-width: 100% to the left gems
Also, for some reason it takes a few moments for the image to load/render (though it's under a second). I think it's because the SVG is complex because of the blurs and such. Maybe in this case it would make more sense to use a rasterized PNG instead
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, just a windows scrollbar issue
using devtool's mobile view it seems the footer still stretches body out because of the margin: 0 -4rem
, but I can't reproduce the issue on Android Chrome, so I'm guessing it's not a real issue
Info
Closes 5 ish
Changes
Screen.Recording.2024-12-09.at.6.03.31.PM.mov
Type of Change
expected)
linting/formatting)
workflows)
Testing
I have tested that my changes fully resolve the linked issue ...
Checklist
/src/lib/*
and commented hard to understand areasanywhere else.