Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dns_active24: rewrite for supporting new v2 API #6197

Open
wants to merge 3 commits into
base: dev
Choose a base branch
from

Conversation

xvybihal
Copy link

@xvybihal xvybihal commented Jan 12, 2025

The active24 provider has migrated it's customers to new API that is the same platform as websupport API. There is new V2 DNS API to manipulate DNS records.

Also V1 API interaction is needed to get the id of service, then use the service_id in V2 requests.

This dns_active24 plugin rewrite should fix failing requests for customers, that were already migrated to new API by active24 (migrations started November 2024).

I have made the rewrite as current plugin maintainer showed no interest in doing so.

Copy link

Welcome
First thing: don't send PR to the master branch, please send to the dev branch instead.
Please make sure you've read our DNS API Dev Guide and DNS-API-Test.
Then reply on this message, otherwise, your code will not be reviewed or merged.
Please also make sure to add/update the usage here: https://github.com/acmesh-official/acme.sh/wiki/dnsapi2
We look forward to reviewing your Pull request shortly ✨
注意: 必须通过了 DNS-API-Test 才会被 review. 无论是修改, 还是新加的 dns api, 都必须确保通过这个测试.

@xvybihal
Copy link
Author

Welcome First thing: don't send PR to the master branch, please send to the dev branch instead. Please make sure you've read our DNS API Dev Guide and DNS-API-Test. Then reply on this message, otherwise, your code will not be reviewed or merged. Please also make sure to add/update the usage here: https://github.com/acmesh-official/acme.sh/wiki/dnsapi2 We look forward to reviewing your Pull request shortly ✨ 注意: 必须通过了 DNS-API-Test 才会被 review. 无论是修改, 还是新加的 dns api, 都必须确保通过这个测试.

Hello, this is my reply

@jursed
Copy link

jursed commented Jan 23, 2025

I pulled your PR and tried it out with --renew-all.

First attempt failed after adding the TXT record with this:

The retryafter=86400 value is too large (> 600), will not retry anymore.

I re-ran it with --debug, but the issue didn't reoccur and the cert renewal succeeded. I don't think your changes affect this part of the code anyway. So it looks fine to me.

(It's certainly better than the current state, where acme.sh stopped working on the new v2 API and the plugin maintainer just went ¯\_(ツ)_/¯)

@xvybihal
Copy link
Author

@jursed really appreciate anyone testing the new version! Thanks. I briefly checked out the error, I have never encountered it, but to me it seems it is not related to the dns_ plugin itself. It appears to be problem with signing request and not with adding values to DNS via API.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants