haproxy.sh: allows certificate deployment to multiple hosts #5180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msimerson
reviewed
Jan 7, 2025
| eval "${_socat_crtlist_show_cmd}" | ||
| export IFS=',' | ||
| for _statssock in ${Le_Deploy_haproxy_stats_socket}; do | ||
| # look for the certificate on the stats socket, to choVse between updating or creating one |
There was a problem hiding this comment.
Suggested change
| # look for the certificate on the stats socket, to choVse between updating or creating one | |
| # look for the certificate on the stats socket, to choose between updating or creating one |
msimerson
reviewed
Jan 7, 2025
| _socat_crtlist_show_cmd="echo '${_cmdpfx}show ssl crt-list' | socat '${_statssock}' - | grep -q '^${Le_Deploy_haproxy_pem_path}$'" | ||
| _debug _socat_crtlist_show_cmd "${_socat_crtlist_show_cmd}" | ||
| eval "${_socat_crtlist_show_cmd}" | ||
| export IFS=',' |
There was a problem hiding this comment.
Suggested change
| export IFS=',' | |
| IFS=',' |
I don't see any reason to export IFS here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
This PR is to allow certificates deployment to multiple HAProxy hosts without needing to reload HAProxy.