fix: read lock -> write lock #333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ws底层会判断当前链接是否已经有消息在写入，如果有消息的同时，再次写入（并发写），会直接 panic, 这个问题是由心跳检查发现调用的sendmsg，但是sendmsg里面用的读锁，并且心跳检查是异步的，当业务里面同时调用了sendmsg ，那么就会触发ws的判断逻辑，导致报错。 这里读锁是可以并发进入逻辑执行的，所以是有问题的。 |
|
sendmsgbuff 其实可以考虑不加锁实现，但是目前先加锁也没啥问题，后面可以优化，因为channel底层本身就有锁，顺带这么一提。 |
Closed
|
好的，感谢 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
用读锁，无法避免并发写入消息，都能走入写消息的逻辑里面，导致并发写入错误