Merge pull request #64 from absurdprofit/development

Update dom-navigation types
absurdprofit · Sep 4, 2024 · 2be0723 · 2be0723
2 parents deacfd4 + 1272819
commit 2be0723
Show file tree

Hide file tree

Showing 6 changed files with 8 additions and 10 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -31,7 +31,7 @@
   },
   "homepage": "https://github.com/nxtexe/react-motion-router#readme",
   "devDependencies": {
-    "@types/dom-navigation": "^1.0.3",
+    "@types/dom-navigation": "^1.0.4",
     "lerna": "^8.1.5",
     "ts-node": "^10.9.2",
     "typescript": "^5.5.2"

diff --git a/packages/core/src/common/types.ts b/packages/core/src/common/types.ts
@@ -123,7 +123,6 @@ export interface LoadNavigationTransition extends Omit<NavigationTransition, "na
 declare global {
     interface NavigateEvent extends Event {
         commit?(): void; // not in spec yet, see https://github.com/WICG/navigation-api/issues/66
-        readonly hasUAVisualTransition: boolean; // not in definitely typed yet, see https://github.com/DefinitelyTyped/DefinitelyTyped/pull/70324
     }
 }
 

diff --git a/packages/core/src/index.ts b/packages/core/src/index.ts
@@ -1,5 +1,4 @@
 /// <reference types="urlpattern-polyfill" />
-/// <reference types="@types/dom-navigation" />
 export * from './SharedElement';
 export * from './RouterBase';
 export * from './ScreenBase';

diff --git a/packages/stack/src/Router.tsx b/packages/stack/src/Router.tsx
@@ -16,7 +16,7 @@ export interface RouterConfig extends RouterBaseConfig {
     disableBrowserRouting?: boolean;
     initialPath?: string;
     shouldIntercept?(navigateEvent: NavigateEvent): boolean;
-    onIntercept?(navigateEvent: NavigateEvent): boolean;
+    onIntercept?(navigateEvent: NavigateEvent): void;
 }
 
 export interface RouterProps extends RouterBaseProps<Screen> {

diff --git a/packages/stack/src/index.ts b/packages/stack/src/index.ts
@@ -1,5 +1,4 @@
 /// <reference types="urlpattern-polyfill" />
-/// <reference types="@types/dom-navigation" />
 import 'web-gesture-events';
 export * from './Navigation';
 export * from './Screen';